diff options
| author | Pedro Alves <palves@redhat.com> | 2017-10-13 11:25:42 +0100 |
|---|---|---|
| committer | Pedro Alves <palves@redhat.com> | 2017-10-13 12:15:52 +0100 |
| commit | df479dc6e045beb77052f96280798e48ee1feb6c (patch) | |
| tree | d644ccd72e8a3741b5d27a3649ce8b84ed881519 /gdb/compile/compile-object-run.c | |
| parent | 23fb630af09f2601e7cb75233837399d67cfd017 (diff) | |
| download | gdb-df479dc6e045beb77052f96280798e48ee1feb6c.zip gdb-df479dc6e045beb77052f96280798e48ee1feb6c.tar.gz gdb-df479dc6e045beb77052f96280798e48ee1feb6c.tar.bz2 | |
Tweak gdb.base/corefile.exp is_remote check
1. Otherwise, when we make native-gdbserver board no longer is_remote,
we get:
Running .../src/gdb/testsuite/gdb.base/corefile.exp ...
ERROR: tcl error sourcing .../src/gdb/testsuite/gdb.base/corefile.exp.
ERROR: gdbserver does not support attach 9327 without extended-remote
while executing
"error "gdbserver does not support $command without extended-remote""
That's fixed by using can_spawn_for_attach instead.
2. The gdb_protocol check fixes this current problem with
--target_board=extended-remote-gdbserver:
Running .../src/gdb/testsuite/gdb.base/corefile.exp ...
FAIL: gdb.base/corefile.exp: run: with core
FAIL: gdb.base/corefile.exp: run: core file is cleared
FAIL: gdb.base/corefile.exp: attach: with core
FAIL: gdb.base/corefile.exp: attach: core file is cleared
gdb.log:
(...)
attach 10859
Don't know how to attach. Try "help target".
(...)
The fix for #2 alone would fix #1 too, but can_spawn_for_attach
expresses the requirement directly, so I still left it there.
gdb/testsuite/ChangeLog:
2017-10-13 Pedro Alves <palves@redhat.com>
* gdb.base/corefile.exp (corefile_test_run): Skip if gdb_protocol
is set.
(corefile_test_attach): Likewise. Check can_spawn_for_attach
instead of is_remote.
Diffstat (limited to 'gdb/compile/compile-object-run.c')
0 files changed, 0 insertions, 0 deletions