aboutsummaryrefslogtreecommitdiff
path: root/gdb/common
diff options
context:
space:
mode:
authorSergio Durigan Junior <sergiodj@redhat.com>2017-06-08 16:58:25 -0400
committerSergio Durigan Junior <sergiodj@redhat.com>2017-06-08 16:58:25 -0400
commit2f91880f3afb3cc521111dfcc99b214c77aa97a1 (patch)
tree391c988b824f89e6689b02900761edd70aed838b /gdb/common
parente3d1d4088ad3b4d0fed39df62ad295ed60707807 (diff)
downloadgdb-2f91880f3afb3cc521111dfcc99b214c77aa97a1.zip
gdb-2f91880f3afb3cc521111dfcc99b214c77aa97a1.tar.gz
gdb-2f91880f3afb3cc521111dfcc99b214c77aa97a1.tar.bz2
Fix possible bug when no args have been provided to the executable
Hi, This bug is related to: <https://sourceware.org/ml/gdb-patches/2017-06/msg00216.html> On stringify_argv, we have to check if args[0] is not NULL before stringifying anything, otherwise we might do the wrong thing when trimming the "ret" string in the end. args[0] will be NULL when no arguments are passed to the inferior that will be started. Checked in as obvious. gdb/ChangeLog: 2017-06-08 Sergio Durigan Junior <sergiodj@redhat.com> * common/common-utils.c (stringify_argv): Check for "arg[0] != NULL".
Diffstat (limited to 'gdb/common')
-rw-r--r--gdb/common/common-utils.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/gdb/common/common-utils.c b/gdb/common/common-utils.c
index 793ab3b..e75a1b9 100644
--- a/gdb/common/common-utils.c
+++ b/gdb/common/common-utils.c
@@ -337,7 +337,7 @@ stringify_argv (const std::vector<char *> &args)
{
std::string ret;
- if (!args.empty ())
+ if (!args.empty () && args[0] != NULL)
{
for (auto s : args)
if (s != NULL)