diff options
author | Tom Tromey <tromey@adacore.com> | 2019-04-30 11:17:15 -0600 |
---|---|---|
committer | Tom Tromey <tromey@adacore.com> | 2019-06-14 14:13:29 -0600 |
commit | 0735b091aba72d4b35aebb671a02c5cb4a837fe9 (patch) | |
tree | c261406309225cb02197ba53b895a8030f0fc442 /gdb/cli | |
parent | 52ce35e2894e55cea94011dda6443be51e154f37 (diff) | |
download | gdb-0735b091aba72d4b35aebb671a02c5cb4a837fe9.zip gdb-0735b091aba72d4b35aebb671a02c5cb4a837fe9.tar.gz gdb-0735b091aba72d4b35aebb671a02c5cb4a837fe9.tar.bz2 |
Do not emit style escape sequences to log file
PR gdb/24502 requests that the "set logging" log file not contain
style escape sequences emitted by gdb.
This seemed like a reasonable request to me, so this patch implements
filtering for the log file.
This also updates a comment in ui-style.h that I noticed while writing
the patch.
Tested on x86-64 Fedora 29.
gdb/ChangeLog
2019-06-14 Tom Tromey <tromey@adacore.com>
PR gdb/24502:
* ui-style.h (skip_ansi_escape): Update comment.
* ui-file.h (class no_terminal_escape_file): New class.
* ui-file.c (no_terminal_escape_file::write)
(no_terminal_escape_file::puts): New methods.
* cli/cli-logging.c (handle_redirections): Use
no_terminal_escape_file.
gdb/testsuite/ChangeLog
2019-06-14 Tom Tromey <tromey@adacore.com>
PR gdb/24502:
* gdb.base/style-logging.exp: New file.
Diffstat (limited to 'gdb/cli')
-rw-r--r-- | gdb/cli/cli-logging.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/gdb/cli/cli-logging.c b/gdb/cli/cli-logging.c index bef5f39..a8b9955 100644 --- a/gdb/cli/cli-logging.c +++ b/gdb/cli/cli-logging.c @@ -100,7 +100,7 @@ handle_redirections (int from_tty) return; } - stdio_file_up log (new stdio_file ()); + stdio_file_up log (new no_terminal_escape_file ()); if (!log->open (logging_filename, logging_overwrite ? "w" : "a")) perror_with_name (_("set logging")); |