aboutsummaryrefslogtreecommitdiff
path: root/gdb/cli
diff options
context:
space:
mode:
authorTom Tromey <tom@tromey.com>2019-06-09 15:21:02 -0600
committerTom Tromey <tromey@adacore.com>2019-07-10 14:53:53 -0600
commit0d12e84cfc9bd36b7bbda01a3c8f83f65a832398 (patch)
treefce7585f8f4259ff311de757c72f5e384ba72e7b /gdb/cli
parentf06f1252b0b8ef20adb4296faaf8293c9d36f615 (diff)
downloadgdb-0d12e84cfc9bd36b7bbda01a3c8f83f65a832398.zip
gdb-0d12e84cfc9bd36b7bbda01a3c8f83f65a832398.tar.gz
gdb-0d12e84cfc9bd36b7bbda01a3c8f83f65a832398.tar.bz2
Don't include gdbarch.h from defs.h
I touched symtab.h and was surprised to see how many files were rebuilt. I looked into it a bit, and found that defs.h includes gdbarch.h, which in turn includes many things. gdbarch.h is only needed by a minority ofthe files in gdb, so this patch removes the include from defs.h and updates the fallout. I did "wc -l" on the files in build/gdb/.deps; this patch reduces the line count from 139935 to 137030; so there are definitely future build-time savings here. Note that while I configured with --enable-targets=all, it's possible that some *-nat.c file needs an update. I could not test all of these. The buildbot caught a few problems along these lines. gdb/ChangeLog 2019-07-10 Tom Tromey <tom@tromey.com> * defs.h: Don't include gdbarch.h. * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h, alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h, ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c, cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h, cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c, compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c, cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c, dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c, dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c, dwarf2expr.c, expression.h, f-lang.c, frame-base.c, frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h, go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c, i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c, linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c, mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c, objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c, parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c, record-btrace.c, record.h, regcache-dump.c, regcache.h, riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y, sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c, sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c, sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h, target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c, tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c, utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c, xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update. * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
Diffstat (limited to 'gdb/cli')
-rw-r--r--gdb/cli/cli-cmds.h1
-rw-r--r--gdb/cli/cli-decode.h1
-rw-r--r--gdb/cli/cli-dump.c1
-rw-r--r--gdb/cli/cli-script.h2
-rw-r--r--gdb/cli/cli-style.h1
5 files changed, 6 insertions, 0 deletions
diff --git a/gdb/cli/cli-cmds.h b/gdb/cli/cli-cmds.h
index 188df05..ac0591e 100644
--- a/gdb/cli/cli-cmds.h
+++ b/gdb/cli/cli-cmds.h
@@ -19,6 +19,7 @@
#include "gdbsupport/filestuff.h"
#include "gdbsupport/gdb_optional.h"
+#include "completer.h"
/* Chain containing all defined commands. */
diff --git a/gdb/cli/cli-decode.h b/gdb/cli/cli-decode.h
index 05280d9..16a6ce9 100644
--- a/gdb/cli/cli-decode.h
+++ b/gdb/cli/cli-decode.h
@@ -25,6 +25,7 @@
#include "command.h"
#include "gdb_regex.h"
#include "cli-script.h"
+#include "completer.h"
#if 0
/* FIXME: cagney/2002-03-17: Once cmd_type() has been removed, ``enum
diff --git a/gdb/cli/cli-dump.c b/gdb/cli/cli-dump.c
index 1910ca2..143d02a 100644
--- a/gdb/cli/cli-dump.c
+++ b/gdb/cli/cli-dump.c
@@ -32,6 +32,7 @@
#include "gdb_bfd.h"
#include "gdbsupport/filestuff.h"
#include "gdbsupport/byte-vector.h"
+#include "gdbarch.h"
static gdb::unique_xmalloc_ptr<char>
scan_expression (const char **cmd, const char *def)
diff --git a/gdb/cli/cli-script.h b/gdb/cli/cli-script.h
index e76e794..387ef88 100644
--- a/gdb/cli/cli-script.h
+++ b/gdb/cli/cli-script.h
@@ -17,6 +17,8 @@
#ifndef CLI_CLI_SCRIPT_H
#define CLI_CLI_SCRIPT_H
+#include "gdbsupport/function-view.h"
+
struct ui_file;
struct cmd_list_element;
diff --git a/gdb/cli/cli-style.h b/gdb/cli/cli-style.h
index 6ae265e..cdcea84 100644
--- a/gdb/cli/cli-style.h
+++ b/gdb/cli/cli-style.h
@@ -21,6 +21,7 @@
#define CLI_CLI_STYLE_H
#include "ui-file.h"
+#include "command.h"
/* A single CLI style option. */
class cli_style_option