aboutsummaryrefslogtreecommitdiff
path: root/gdb/cli
diff options
context:
space:
mode:
authorChristian Biesinger <cbiesinger@google.com>2019-10-09 23:27:33 -0500
committerChristian Biesinger <cbiesinger@google.com>2019-10-12 14:31:26 -0500
commitcc8dee1f1c67be4155225c6c29dc1245abb89812 (patch)
treeeed9d10ce5704b5174f1484a3e5203605e339daf /gdb/cli
parent03d0d46a0e60203528f8d385a4136c870ff02261 (diff)
downloadgdb-cc8dee1f1c67be4155225c6c29dc1245abb89812.zip
gdb-cc8dee1f1c67be4155225c6c29dc1245abb89812.tar.gz
gdb-cc8dee1f1c67be4155225c6c29dc1245abb89812.tar.bz2
Move declaration of max_user_call_depth to header
Also removes an unnecessary declaration of cmdlist in cli-cmds.c. I don't understand why it is there, the definition of cmdlist is at the top of the same file. gdb/ChangeLog: 2019-10-12 Christian Biesinger <cbiesinger@google.com> * cli/cli-cmds.c (max_user_call_depth): Move comment to header. (show_user): Remove declaration of cmdlist. * cli/cli-cmds.h (max_user_call_depth): Declare. * cli/cli-script.c (execute_user_command): Remove declaration of max_user_call_depth.
Diffstat (limited to 'gdb/cli')
-rw-r--r--gdb/cli/cli-cmds.c3
-rw-r--r--gdb/cli/cli-cmds.h4
-rw-r--r--gdb/cli/cli-script.c1
3 files changed, 5 insertions, 3 deletions
diff --git a/gdb/cli/cli-cmds.c b/gdb/cli/cli-cmds.c
index 9f7b052..a39ea22 100644
--- a/gdb/cli/cli-cmds.c
+++ b/gdb/cli/cli-cmds.c
@@ -74,7 +74,7 @@ static void ambiguous_line_spec (gdb::array_view<const symtab_and_line> sals,
static void filter_sals (std::vector<symtab_and_line> &);
-/* Limit the call depth of user-defined commands */
+/* See cli-cmds.h. */
unsigned int max_user_call_depth;
/* Define all cmd_list_elements. */
@@ -1538,7 +1538,6 @@ static void
show_user (const char *args, int from_tty)
{
struct cmd_list_element *c;
- extern struct cmd_list_element *cmdlist;
if (args)
{
diff --git a/gdb/cli/cli-cmds.h b/gdb/cli/cli-cmds.h
index 1a8b9a0..94ae814 100644
--- a/gdb/cli/cli-cmds.h
+++ b/gdb/cli/cli-cmds.h
@@ -101,6 +101,10 @@ extern struct cmd_list_element *setchecklist;
extern struct cmd_list_element *showchecklist;
+/* Limit the call depth of user-defined commands */
+
+extern unsigned int max_user_call_depth;
+
/* Exported to gdb/top.c */
void init_cmd_lists (void);
diff --git a/gdb/cli/cli-script.c b/gdb/cli/cli-script.c
index 4fc9c70..3137955 100644
--- a/gdb/cli/cli-script.c
+++ b/gdb/cli/cli-script.c
@@ -449,7 +449,6 @@ void
execute_user_command (struct cmd_list_element *c, const char *args)
{
counted_command_line cmdlines_copy;
- extern unsigned int max_user_call_depth;
/* Ensure that the user commands can't be deleted while they are
executing. */