diff options
author | Alan Hayward <alan.hayward@arm.com> | 2019-05-17 14:15:01 +0100 |
---|---|---|
committer | Alan Hayward <alan.hayward@arm.com> | 2019-05-17 14:21:47 +0100 |
commit | ca1285d17534cff3041c07ac7841288e1b3ba19c (patch) | |
tree | 5cc51bf559c3464bf1c43704e6fa94d93b1c0bc4 /gdb/cli/cli-logging.c | |
parent | 334fe02b5f9cb1dd3abb0f79856ee1f4285f39c1 (diff) | |
download | gdb-ca1285d17534cff3041c07ac7841288e1b3ba19c.zip gdb-ca1285d17534cff3041c07ac7841288e1b3ba19c.tar.gz gdb-ca1285d17534cff3041c07ac7841288e1b3ba19c.tar.bz2 |
Add debug redirect option
Currently, when logging is enabled, output will be sent to both a
logfile and standard terminal output. The redirect option sends output
only to the logfile. This includes all debug output.
Add the option to redirect debug output seperately to normal
output, using the cli command:
set logging debugredirect on
By setting this and enabling logging, all output and debug will
be sent to the logfile. The user will still see all output but
no debug output.
This causes a change in behaviour for anyone currently using
logging redirect, as now only output will be redirected. Users
will have to issue the additional command above to also redirect
debug.
Expand ui-redirect.exp cover the changes.
gdb/ChangeLog:
* cli/cli-interp.c (struct saved_output_files): Add saved entry.
(cli_interp_base::set_logging): Check debug_redirect.
* cli/cli-interp.h (set_logging): Add debug_redirect parameter.
* cli/cli-logging.c (debug_redirect): Add static variable.
(pop_output_files): Add default param.
(handle_redirections): Print debug setting.
(show_logging_command): Likewise.
(_initialize_cli_logging): Add debugredirect command.
* interps.c (current_interp_set_logging): Add debug_redirect
parameter.
* interps.h (set_logging): Add debug_redirect parameter.
(current_interp_set_logging): Likewise.
* mi/mi-common.h: Likewise.
* mi/mi-interp.c (mi_interp::set_logging): Likewise.
gdb/testsuite/ChangeLog:
* gdb.base/ui-redirect.exp: Add debug redirect tests.
Diffstat (limited to 'gdb/cli/cli-logging.c')
-rw-r--r-- | gdb/cli/cli-logging.c | 27 |
1 files changed, 25 insertions, 2 deletions
diff --git a/gdb/cli/cli-logging.c b/gdb/cli/cli-logging.c index 670e7e2..bef5f39 100644 --- a/gdb/cli/cli-logging.c +++ b/gdb/cli/cli-logging.c @@ -62,6 +62,7 @@ show_logging_overwrite (struct ui_file *file, int from_tty, /* Value as configured by the user. */ static int logging_redirect; +static int debug_redirect; static void set_logging_redirect (const char *args, @@ -81,7 +82,7 @@ show_logging_redirect (struct ui_file *file, int from_tty, static void pop_output_files (void) { - current_interp_set_logging (NULL, false); + current_interp_set_logging (NULL, false, false); /* Stay consistent with handle_redirections. */ if (!current_uiout->is_mi_like_p ()) @@ -112,12 +113,20 @@ handle_redirections (int from_tty) else fprintf_unfiltered (gdb_stdout, "Redirecting output to %s.\n", logging_filename); + + if (!debug_redirect) + fprintf_unfiltered (gdb_stdout, "Copying debug output to %s.\n", + logging_filename); + else + fprintf_unfiltered (gdb_stdout, "Redirecting debug output to %s.\n", + logging_filename); } saved_filename = xstrdup (logging_filename); /* Let the interpreter do anything it needs. */ - current_interp_set_logging (std::move (log), logging_redirect); + current_interp_set_logging (std::move (log), logging_redirect, + debug_redirect); /* Redirect the current ui-out object's output to the log. Use gdb_stdout, not log, since the interpreter may have created a tee @@ -185,6 +194,11 @@ show_logging_command (const char *args, int from_tty) printf_unfiltered (_("Output will be sent only to the log file.\n")); else printf_unfiltered (_("Output will be logged and displayed.\n")); + + if (debug_redirect) + printf_unfiltered (_("Debug output will be sent only to the log file.\n")); + else + printf_unfiltered (_("Debug output will be logged and displayed.\n")); } void @@ -213,6 +227,15 @@ If redirect is on, output will go only to the log file."), set_logging_redirect, show_logging_redirect, &set_logging_cmdlist, &show_logging_cmdlist); + add_setshow_boolean_cmd ("debugredirect", class_support, + &debug_redirect, _("\ +Set the logging debug output mode."), _("\ +Show the logging debug output mode."), _("\ +If debug redirect is off, debug will go to both the screen and the log file.\n\ +If debug redirect is on, debug will go only to the log file."), + set_logging_redirect, + show_logging_redirect, + &set_logging_cmdlist, &show_logging_cmdlist); add_setshow_filename_cmd ("file", class_support, &logging_filename, _("\ Set the current logfile."), _("\ Show the current logfile."), _("\ |