diff options
| author | Tom Tromey <tromey@redhat.com> | 2013-05-30 16:24:36 +0000 |
|---|---|---|
| committer | Tom Tromey <tromey@redhat.com> | 2013-05-30 16:24:36 +0000 |
| commit | 5b3fca71ae2013ecb997f9d71c3fc7dfdf69936d (patch) | |
| tree | 18f8aa52e4b42f2ea624240679e698f6aef8d181 /gdb/cli/cli-dump.c | |
| parent | af83e3f886c6e098f997d6f03dcf5e807a14a4f2 (diff) | |
| download | gdb-5b3fca71ae2013ecb997f9d71c3fc7dfdf69936d.zip gdb-5b3fca71ae2013ecb997f9d71c3fc7dfdf69936d.tar.gz gdb-5b3fca71ae2013ecb997f9d71c3fc7dfdf69936d.tar.bz2 | |
some cleanup checker fixes
Fix some bugs pointed out by the cleanup checker. This one just fixes
some simple CLI reports, where CLI commands know that their caller
will do cleanups. This an older style with few instances, so it is
simpler to fix them up than to teach the checker about it.
* cli/cli-cmds.c (cd_command, alias_command): Call do_cleanups.
* cli/cli-dump.c (restore_binary_file): Call do_cleanups.
* interps.c (interpreter_exec_cmd): Call do_cleanups.
* source.c (show_substitute_path_command): Call do_cleanups.
(unset_substitute_path_command, set_substitute_path_command):
Likewise.
* symfile.c (load_command): Call do_cleanups.
Diffstat (limited to 'gdb/cli/cli-dump.c')
| -rw-r--r-- | gdb/cli/cli-dump.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/gdb/cli/cli-dump.c b/gdb/cli/cli-dump.c index 529e0a0..208916c 100644 --- a/gdb/cli/cli-dump.c +++ b/gdb/cli/cli-dump.c @@ -508,6 +508,7 @@ restore_section_callback (bfd *ibfd, asection *isec, void *args) static void restore_binary_file (char *filename, struct callback_data *data) { + struct cleanup *cleanup = make_cleanup (null_cleanup, NULL); FILE *file = fopen_with_cleanup (filename, FOPEN_RB); gdb_byte *buf; long len; @@ -553,7 +554,7 @@ restore_binary_file (char *filename, struct callback_data *data) len = target_write_memory (data->load_start + data->load_offset, buf, len); if (len != 0) warning (_("restore: memory write failed (%s)."), safe_strerror (len)); - return; + do_cleanups (cleanup); } static void |