diff options
| author | Keith Seitz <keiths@redhat.com> | 2015-06-04 10:13:50 -0700 |
|---|---|---|
| committer | Keith Seitz <keiths@redhat.com> | 2015-06-24 14:09:19 -0700 |
| commit | 32fad71f9e6cdf73fe3c10123b23f42397b83e7d (patch) | |
| tree | d0d92e32a7e585ea3efb0bab5c08d96c4781428f /gdb/build-id.c | |
| parent | 7c1e8d3ed5e48b3339d60450fdb5b29ae54edebe (diff) | |
| download | gdb-32fad71f9e6cdf73fe3c10123b23f42397b83e7d.zip gdb-32fad71f9e6cdf73fe3c10123b23f42397b83e7d.tar.gz gdb-32fad71f9e6cdf73fe3c10123b23f42397b83e7d.tar.bz2 | |
Fix lrealpath memory leak in build_id_to_debug_bfd
Valgrind reports memory leaking from build_id_to_debug_bfd:
==7261== 88 bytes in 2 blocks are definitely lost in loss record 31,319 of 35,132
==7261== at 0x4A06BCF: malloc (vg_replace_malloc.c:296)
==7261== by 0x32CA88A9B9: strdup (strdup.c:42)
==7261== by 0xFE62AB: lrealpath (lrealpath.c:88)
==7261== by 0x7F7AD6: build_id_to_debug_bfd (build-id.c:116)
==7261== by 0x7F7BB5: find_separate_debug_file_by_buildid (build-id.c:149)
==7261== by 0x6D9382: elf_symfile_read (elfread.c:1348)
==7261== by 0x777F02: read_symbols (symfile.c:875)
==7261== by 0x778505: syms_from_objfile_1 (symfile.c:1078)
==7261== by 0x778548: syms_from_objfile (symfile.c:1094)
==7261== by 0x778746: symbol_file_add_with_addrs (symfile.c:1191)
==7261== by 0x77893B: symbol_file_add_from_bfd (symfile.c:1280)
==7261== by 0x8E51E3: solib_read_symbols (solib.c:706)
==7261== by 0x8E58AF: solib_add (solib.c:1029)
This occurs because commit 1be5090b in bfd, addressing PR 11983, started
taking a copy of the input filename instead of directly caching it. It
appears that this code was never updated to reflect that API change.
This simple patch creates a cleanup to free the return value for lrealpath.
gdb/ChangeLog
* build-id.c (build_id_to_debug_bfd): Add cleanup to free
return value from lrealpath.
Diffstat (limited to 'gdb/build-id.c')
| -rw-r--r-- | gdb/build-id.c | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/gdb/build-id.c b/gdb/build-id.c index ebf9f45..c89cd55 100644 --- a/gdb/build-id.c +++ b/gdb/build-id.c @@ -93,6 +93,7 @@ build_id_to_debug_bfd (size_t build_id_len, const bfd_byte *build_id) size_t size = build_id_len; char *s; char *filename = NULL; + struct cleanup *inner; memcpy (link, debugdir, debugdir_len); s = &link[debugdir_len]; @@ -116,7 +117,10 @@ build_id_to_debug_bfd (size_t build_id_len, const bfd_byte *build_id) continue; /* We expect to be silent on the non-existing files. */ + inner = make_cleanup (xfree, filename); abfd = gdb_bfd_open (filename, gnutarget, -1); + do_cleanups (inner); + if (abfd == NULL) continue; |