diff options
author | Pedro Alves <palves@redhat.com> | 2018-04-26 13:01:26 +0100 |
---|---|---|
committer | Pedro Alves <palves@redhat.com> | 2018-04-26 13:05:58 +0100 |
commit | 28f4fa4d0540ac6a23930202f39782167667e373 (patch) | |
tree | fe851d3ea6e24366d6826e14b38d277a4430e416 /gdb/breakpoint.h | |
parent | ca31ab1d675c1e20cee5f8cb213c52e3d7352496 (diff) | |
download | gdb-28f4fa4d0540ac6a23930202f39782167667e373.zip gdb-28f4fa4d0540ac6a23930202f39782167667e373.tar.gz gdb-28f4fa4d0540ac6a23930202f39782167667e373.tar.bz2 |
Fix elf_gnu_ifunc_resolve_by_got buglet
The next patch will add a call to elf_gnu_ifunc_resolve_by_got that
trips on a latent buglet -- the function is writing to its output
parameter even if the address wasn't found, confusing the caller. The
function's intro comment says:
/* Try to find the target resolved function entry address of a STT_GNU_IFUNC
function NAME. If the address is found it is stored to *ADDR_P (if ADDR_P
is not NULL) and the function returns 1. It returns 0 otherwise.
So fix the function accordingly.
gdb/ChangeLog:
2018-04-26 Pedro Alves <palves@redhat.com>
* elfread.c (elf_gnu_ifunc_resolve_by_got): Don't write to *ADDR_P
unless we actually resolved the ifunc.
Diffstat (limited to 'gdb/breakpoint.h')
0 files changed, 0 insertions, 0 deletions