diff options
| author | Tom Tromey <tom@tromey.com> | 2017-11-03 10:26:11 -0600 |
|---|---|---|
| committer | Tom Tromey <tom@tromey.com> | 2017-12-07 14:52:20 -0700 |
| commit | 99598d713f45d1b26015ec3562d160dc2b3792e4 (patch) | |
| tree | c05903c42377f84f31772df09cc1e4f86eb0b60c /gdb/breakpoint.c | |
| parent | 23a8d1862b7e5b95f0fe9d724c6be326e545e6d1 (diff) | |
| download | gdb-99598d713f45d1b26015ec3562d160dc2b3792e4.zip gdb-99598d713f45d1b26015ec3562d160dc2b3792e4.tar.gz gdb-99598d713f45d1b26015ec3562d160dc2b3792e4.tar.bz2 | |
Fix regression in "commands"
Pedro pointed out a regression in "commands", where trying to clear a
breakpoint's command list would fail:
(top-gdb) commands
Type commands for breakpoint(s) 3, one per line.
End with a line saying just "end".
>end
No breakpoints specified.
(top-gdb)
I believe the bug was introduced by my patch that changes
counted_command_line to be a shared_ptr. This causes the problem
because now the counted_command_line in commands_command_1 can be NULL,
whereas previously it never could be.
After some discussion, we agreed to simply remove the error case from
commands_command_1.
2017-12-07 Tom Tromey <tom@tromey.com>
PR breakpoints/22511:
* breakpoint.c (commands_command_1): Don't throw an exception when
no commands have been read.
2017-12-07 Tom Tromey <tom@tromey.com>
* gdb.base/break.exp: Add test for empty "commands".
Diffstat (limited to 'gdb/breakpoint.c')
| -rw-r--r-- | gdb/breakpoint.c | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/gdb/breakpoint.c b/gdb/breakpoint.c index 76bfd53..59a4dad 100644 --- a/gdb/breakpoint.c +++ b/gdb/breakpoint.c @@ -1272,9 +1272,6 @@ commands_command_1 (const char *arg, int from_tty, observer_notify_breakpoint_modified (b); } }); - - if (cmd == NULL) - error (_("No breakpoints specified.")); } static void |