diff options
| author | Tom Tromey <tom@tromey.com> | 2023-07-09 18:46:53 -0600 |
|---|---|---|
| committer | Tom Tromey <tom@tromey.com> | 2023-07-10 15:43:08 -0600 |
| commit | 57685738614a0089fba7f79669392b8d66d7c6af (patch) | |
| tree | 0a18ff62ea218beea528c373209ddfbdfb12b22f /gdb/bfd-target.c | |
| parent | 9fe01a376b2fb096e4836e985ba316ce9dc02399 (diff) | |
| download | gdb-57685738614a0089fba7f79669392b8d66d7c6af.zip gdb-57685738614a0089fba7f79669392b8d66d7c6af.tar.gz gdb-57685738614a0089fba7f79669392b8d66d7c6af.tar.bz2 | |
Remove target_close
I noticed that target_close is only called in two places:
solib-svr4.c, and target_ops_ref_policy::decref.
This patch fixes the former by changing target_bfd_reopen to return a
target_ops_up and then fixing the sole caller. Then it removes
target_close by inlining its body into the decref method.
The advantage of this approach is that targets are now automatically
managed.
Regression tested on x86-64 Fedora 38.
Approved-By: Andrew Burgess <aburgess@redhat.com>
Diffstat (limited to 'gdb/bfd-target.c')
| -rw-r--r-- | gdb/bfd-target.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/gdb/bfd-target.c b/gdb/bfd-target.c index 6b8a839..9e1b980 100644 --- a/gdb/bfd-target.c +++ b/gdb/bfd-target.c @@ -94,10 +94,10 @@ target_bfd::target_bfd (const gdb_bfd_ref_ptr &abfd) { } -target_ops * +target_ops_up target_bfd_reopen (const gdb_bfd_ref_ptr &abfd) { - return new target_bfd (abfd); + return target_ops_up (new target_bfd (abfd)); } void |