diff options
author | Michael Snyder <msnyder@vmware.com> | 2011-01-07 19:36:19 +0000 |
---|---|---|
committer | Michael Snyder <msnyder@vmware.com> | 2011-01-07 19:36:19 +0000 |
commit | 0963b4bd458eab010b3b19c9ffd8eb790f2cd06c (patch) | |
tree | 42dcaac763368854d136093c43a40333b751d391 /gdb/ada-tasks.c | |
parent | 87973e9f82d516acbf4f484ba56febe17a3b312d (diff) | |
download | gdb-0963b4bd458eab010b3b19c9ffd8eb790f2cd06c.zip gdb-0963b4bd458eab010b3b19c9ffd8eb790f2cd06c.tar.gz gdb-0963b4bd458eab010b3b19c9ffd8eb790f2cd06c.tar.bz2 |
2011-01-07 Michael Snyder <msnyder@vmware.com>
* ada-lang.c: Comment cleanup, mostly periods and spaces.
* ada-lang.h: Ditto.
* ada-tasks.c: Ditto.
* ada-valprint.c: Ditto.
* aix-threads.c: Ditto.
* alpha-linux-nat.c: Ditto.
* alpha-linux-tdep.c: Ditto.
* alpha-mdebug-tdep.c: Ditto.
* alpha-nat.c: Ditto.
* alpha-osf1-tdep.c: Ditto.
* alpha-tdep.c: Ditto.
* alphabsd-nat.c: Ditto.
* alphabsd-tdep.c: Ditto.
* amd64-darwin-tdep.c: Ditto.
* amd64-linux-nat.c: Ditto.
* amd64-linux-tdep.c: Ditto.
* amd64-sol2-tdep.c: Ditto.
* amd64-tdep.c: Ditto.
* amd64-fbsd-tdep.c: Ditto.
* amd64-nbsd-tdep.c: Ditto.
* amd64-obsd-tdep.c: Ditto.
* amd64-linux-nat.c: Ditto.
* amd64-linux-tdep.c: Ditto.
* arm-tdep.c: Ditto.
* arm-tdep.h: Ditto.
* armnbsd-nat.c: Ditto.
* avr-tdep.c: Ditto.
* bfin-tdep.c: Ditto.
* bsd-kvm.c: Ditto.
* c-typeprintc: Ditto.
* c-valprint.c: Ditto.
* coff-pe-read.h: Ditto.
* coffreead.c: Ditto.
* cris-tdep.c: Ditto.
* d-lang.c: Ditto.
* darwin-nat-info.c: Ditto.
* darwin-nat.c: Ditto.
* dbug-rom.c: Ditto.
* dbxread.c: Ditto.
* dcache.c: Ditto.
* dcache.h: Ditto.
* dec-thread.c: Ditto.
* defs.h: Ditto.
* demangle.c: Ditto.
* dicos-tdep.c: Ditto.
* dictionary.c: Ditto.
* dictionary.h: Ditto.
* dink32-rom.c: Ditto.
* disasm.c: Ditto.
* doublest.c: Ditto.
* dsrec.c: Ditto.
* dummy-frame.c: Ditto.
* dwarf2-frame.c: Ditto.
* dwarf2expr.c: Ditto.
* dwarf2loc.c: Ditto.
* dwarf2read.c: Ditto.
* elfread.c: Ditto.
* environ.c: Ditto.
* eval.c: Ditto.
* event-top.h: Ditto.
* exceptions.c: Ditto.
* exceptions.h: Ditto.
* exec.c: Ditto.
* expprint.c: Ditto.
* expression.h: Ditto.
* f-exp.y: Ditto.
* f-lang.c: Ditto.
* f-lang.h: Ditto.
* f-typeprint.c: Ditto.
* f-valprint.c: Ditto.
* fbsd-nat.c: Ditto.
* findvar.c: Ditto.
* fork-child.c: Ditto.
* frame.c: Ditto.
* frame.h: Ditto.
* frv-linux-tdep.c: Ditto.
* frv-tdep.c: Ditto.
* gcore.c: Ditto.
* gdb-stabs.h: Ditto.
* gdb_assert.h: Ditto.
* gdb_string.h: Ditto.
* gdb_thread_db.h: Ditto.
* gdb_wait.h: Ditto.
* gdbarch.sh: Ditto.
* gdbcore.h: Ditto.
* gdbthread.h: Ditto.
* gdbtypes.c: Ditto.
* gdbtypes.h: Ditto.
* gnu-nat.c: Ditto.
* gnu-nat.h: Ditto.
* gnu-v2-abi.c: Ditto.
* gnu-v3-abi.c: Ditto.
* go32-nat.c: Ditto.
* gdbarch.c: Regenerate.
* gdbarch.h: Regenerate.
Diffstat (limited to 'gdb/ada-tasks.c')
-rw-r--r-- | gdb/ada-tasks.c | 24 |
1 files changed, 12 insertions, 12 deletions
diff --git a/gdb/ada-tasks.c b/gdb/ada-tasks.c index 33a1760..216902a 100644 --- a/gdb/ada-tasks.c +++ b/gdb/ada-tasks.c @@ -126,7 +126,7 @@ struct tcb_fieldnos }; /* The type description for the ATCB record and subrecords, and - the associated tcb_fieldnos. For efficiency reasons, these are made + the associated tcb_fieldnos. For efficiency reasons, these are made static globals so that we can compute them only once the first time and reuse them later. Set to NULL if the types haven't been computed yet, or if they may be obsolete (for instance after having loaded @@ -305,7 +305,7 @@ read_fat_string_value (char *dest, struct value *val, int max_len) In order to provide a fast response time, this function caches the Known_Tasks array address after the lookup during the first - call. Subsequent calls will simply return this cached address. */ + call. Subsequent calls will simply return this cached address. */ static CORE_ADDR get_known_tasks_addr (void) @@ -327,21 +327,21 @@ get_known_tasks_addr (void) /* FIXME: brobecker 2003-03-05: Here would be a much better place to attach the ada-tasks observers, instead of doing this - unconditionaly in _initialize_tasks. This would avoid an + unconditionaly in _initialize_tasks. This would avoid an unecessary notification when the inferior does not use tasking or as long as the user does not use the ada-tasks commands. Unfortunately, this is not possible for the moment: the current code resets ada__tasks_check_symbol_table back to 1 whenever - symbols for a new program are being loaded. If we place the + symbols for a new program are being loaded. If we place the observers intialization here, we will end up adding new observers everytime we do the check for Ada tasking-related symbols - above. This would currently have benign effects, but is still - undesirable. The cleanest approach is probably to create a new + above. This would currently have benign effects, but is still + undesirable. The cleanest approach is probably to create a new observer to notify us when the user is debugging a new program. We would then reset ada__tasks_check_symbol_table back to 1 during the notification, but also detach all observers. BTW: observers are probably not reentrant, so detaching during - a notification may not be the safest thing to do... Sigh... + a notification may not be the safest thing to do... Sigh... But creating the new observer would be a good idea in any case, since this allow us to make ada__tasks_check_symbol_table static, which is a good bonus. */ @@ -380,7 +380,7 @@ get_tcb_types_info (struct type **atcb_type, const char *private_data_name = "system__task_primitives__private_data"; const char *entry_call_record_name = "system__tasking__entry_call_record"; - /* ATCB symbols may be found in several compilation units. As we + /* ATCB symbols may be found in several compilation units. As we are only interested in one instance, use standard (literal, C-like) lookups to get the first match. */ @@ -521,14 +521,14 @@ read_atcb (CORE_ADDR task_id, struct ada_task_info *task_info) Depending on the GNAT version used, the task image is either a fat string, or a thin array of characters. Older versions of GNAT used to use fat strings, and therefore did not need an extra field in - the ATCB to store the string length. For efficiency reasons, newer + the ATCB to store the string length. For efficiency reasons, newer versions of GNAT replaced the fat string by a static buffer, but this also required the addition of a new field named "Image_Len" containing - the length of the task name. The method used to extract the task name + the length of the task name. The method used to extract the task name is selected depending on the existence of this field. In some run-time libs (e.g. Ravenscar), the name is not in the ATCB; - we may want to get it from the first user frame of the stack. For now, + we may want to get it from the first user frame of the stack. For now, we just give a dummy name. */ if (fieldno.image_len == -1) @@ -762,7 +762,7 @@ short_task_info (int taskno) } /* Print a list containing a short description of all Ada tasks. */ -/* FIXME: Shouldn't we be using ui_out??? */ +/* FIXME: Shouldn't we be using ui_out??? */ static void info_tasks (int from_tty) |