diff options
author | Tom Tromey <tom@tromey.com> | 2020-11-30 01:37:10 -0700 |
---|---|---|
committer | Tom Tromey <tom@tromey.com> | 2020-11-30 01:37:10 -0700 |
commit | 88b91969e1ae5d23f81b86ae6cd3c85b284c6294 (patch) | |
tree | 33a677f9adac503851cc9e659d7e2b896e11dddd /gdb/ada-lang.c | |
parent | 1cd49c43f340e4de62922356ed859ee806e52f6f (diff) | |
download | gdb-88b91969e1ae5d23f81b86ae6cd3c85b284c6294.zip gdb-88b91969e1ae5d23f81b86ae6cd3c85b284c6294.tar.gz gdb-88b91969e1ae5d23f81b86ae6cd3c85b284c6294.tar.bz2 |
Remove per-language op_name functions
enum exp_opcode is created from all the .def files, but then each
language is required to implement its own op_name function to turn an
enum value to a string. This seemed over-complicated to me, and this
patch removes the per-language functions in favor of simply using the
.def names for all languages. Note that op_name is only used for
dumping expressions, which is a maintainer/debug feature.
Furthermore, I don't think there was any case where the .def name and
the string name differed.
gdb/ChangeLog
2020-11-30 Tom Tromey <tom@tromey.com>
* rust-lang.c (rust_op_name): Remove.
(exp_descriptor_rust): Update.
* parser-defs.h (op_name_standard): Don't declare.
(struct exp_descriptor) <op_name>: Remove.
* parse.c (exp_descriptor_standard): Update.
* opencl-lang.c (exp_descriptor_opencl): Update.
* m2-lang.c (m2_language::exp_descriptor_modula2): Update.
* f-lang.c (op_name_f): Remove.
(f_language::exp_descriptor_tab): Update.
* expression.h (op_name): Update.
* expprint.c (op_name): Rewrite.
(op_name_standard): Remove.
(dump_raw_expression, dump_subexp): Update.
* c-lang.c (exp_descriptor_c): Update.
* ax-gdb.c (gen_expr): Update.
* ada-lang.c (ada_op_name): Remove.
(ada_exp_descriptor): Update.
Diffstat (limited to 'gdb/ada-lang.c')
-rw-r--r-- | gdb/ada-lang.c | 24 |
1 files changed, 0 insertions, 24 deletions
diff --git a/gdb/ada-lang.c b/gdb/ada-lang.c index 714227d..9066711 100644 --- a/gdb/ada-lang.c +++ b/gdb/ada-lang.c @@ -127,8 +127,6 @@ static void replace_operator_with_call (expression_up *, int, int, int, static int possible_user_operator_p (enum exp_opcode, struct value **); -static const char *ada_op_name (enum exp_opcode); - static const char *ada_decoded_op_name (enum exp_opcode); static int numeric_type_p (struct type *); @@ -13289,27 +13287,6 @@ ada_operator_check (struct expression *exp, int pos, return 0; } -static const char * -ada_op_name (enum exp_opcode opcode) -{ - switch (opcode) - { - default: - return op_name_standard (opcode); - -#define OP_DEFN(op, len, args, binop) case op: return #op; - ADA_OPERATORS; -#undef OP_DEFN - - case OP_AGGREGATE: - return "OP_AGGREGATE"; - case OP_CHOICES: - return "OP_CHOICES"; - case OP_NAME: - return "OP_NAME"; - } -} - /* As for operator_length, but assumes PC is pointing at the first element of the operator, and gives meaningful results only for the Ada-specific operators, returning 0 for *OPLENP and *ARGSP otherwise. */ @@ -13601,7 +13578,6 @@ static const struct exp_descriptor ada_exp_descriptor = { ada_print_subexp, ada_operator_length, ada_operator_check, - ada_op_name, ada_dump_subexp_body, ada_evaluate_subexp }; |