diff options
| author | Andrew Burgess <andrew.burgess@embecosm.com> | 2020-07-12 15:09:52 +0100 |
|---|---|---|
| committer | Andrew Burgess <andrew.burgess@embecosm.com> | 2020-09-16 11:04:03 +0100 |
| commit | 0d201fa46059ddd27980ccf8cca8488ac98b89be (patch) | |
| tree | 3bbb11e9ef64b1a8a6781aed8f094a8f07286a9f /gdb/ada-lang.c | |
| parent | efdf6a733d2a59a1a07ec61e848fa9e128259fe3 (diff) | |
| download | gdb-0d201fa46059ddd27980ccf8cca8488ac98b89be.zip gdb-0d201fa46059ddd27980ccf8cca8488ac98b89be.tar.gz gdb-0d201fa46059ddd27980ccf8cca8488ac98b89be.tar.bz2 | |
gdb: Convert language_data::la_case_sensitivity to a method
Convert language_data::la_case_sensitivity member variable to a virtual
method language_defn::case_sensitivity.
This is mostly straight forward. The only slight problem is that I
ended up deleting this comment from ada-lang.c:
/* Yes, Ada is case-insensitive, but that's not quite what this
means. */
However, as the comment (which has existed since Ada support was first
added to GDB) doesn't explain _why_ Ada sets case sensitivity to on
despite being a generally case insensitive language, this doesn't
really help me much.
If I understood _why_ the setting doesn't quite mean what it seems to
mean (at least as far as Ada is concerned) then I would extend the
comment on language_defn::case_sensitivity (in language.h) to include
the detail, and note how this impacts Ada. But as it stands I've just
deleted the comment for now.
There should be no user visible changes after this commit.
gdb/ChangeLog:
* ada-lang.c (ada_language_data): Remove la_case_sensitivity
initializer.
* c-lang.c (c_language_data): Likewise.
(cplus_language_data): Likewise.
(asm_language_data): Likewise.
(minimal_language_data): Likewise.
* d-lang.c (d_language_data): Likewise.
* f-lang.c (f_language_data): Likewise.
(f_language::case_sensitivity): New member function.
* go-lang.c (go_language_data): Remove la_case_sensitivity
initializer.
* language.c (enum case_mode): Moved here from language.h.
(case_mode): Make static.
(show_case_command): Update for case_sensitivity being a method.
(set_case_command): Likewise.
(set_range_case): Likewise.
(unknown_language_data): Remove la_case_sensitivity initializer.
(auto_language_data): Likewise.
* language.h (case_mode): Delete, move enum declaration to
language.c.
(language_data): Delete la_case_sensitivity field.
(language_defn::case_sensitivity): New member function.
* m2-lang.c (m2_language_data): Remove la_case_sensitivity
initializer.
* objc-lang.c (objc_language_data): Likewise.
* opencl-lang.c (opencl_language_data): Likewise.
* p-lang.c (pascal_language_data): Likewise.
* rust-lang.c (rust_language_data): Likewise.
Diffstat (limited to 'gdb/ada-lang.c')
| -rw-r--r-- | gdb/ada-lang.c | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/gdb/ada-lang.c b/gdb/ada-lang.c index 0a0dc21..bb850c1 100644 --- a/gdb/ada-lang.c +++ b/gdb/ada-lang.c @@ -13708,8 +13708,6 @@ ada_get_symbol_name_matcher (const lookup_name_info &lookup_name) extern const struct language_data ada_language_data = { - case_sensitive_on, /* Yes, Ada is case-insensitive, but - that's not quite what this means. */ array_row_major, macro_expansion_no, &ada_exp_descriptor, |