diff options
| author | Pedro Alves <palves@redhat.com> | 2017-04-18 21:39:24 +0100 |
|---|---|---|
| committer | Pedro Alves <palves@redhat.com> | 2017-04-18 23:49:33 +0100 |
| commit | d35d19584cf56a50b4833ff9c003597e01022f27 (patch) | |
| tree | f6b290e1bf598870c929e5399df235b5e1ce17ae /gdb/Makefile.in | |
| parent | 22796e972f18c5601cecb0251222411a352836b6 (diff) | |
| download | gdb-d35d19584cf56a50b4833ff9c003597e01022f27.zip gdb-d35d19584cf56a50b4833ff9c003597e01022f27.tar.gz gdb-d35d19584cf56a50b4833ff9c003597e01022f27.tar.bz2 | |
gdb::optional unit tests
I thought I'd add some unit tests to make sure gdb::optional behaved
correctly, and started writing some, but then thought/realized that
libstdc++ already has extensive testing for C++17 std::optional, which
gdb::optional is a subset of, and thought why bother writing something
from scratch. So I tried copying over a subset of libstdc++'s tests
(that ones that cover the subset supported by gdb::optional), and was
positively surprised that they mostly work OOTB. This did help shake
out a few bugs from what I was implementing in the previous patch to
gdb::optional. Still, it's a good chunk of code being copied over, so
if people dislike this copying/duplication, I can drop this patch.
gdb/ChangeLog:
2017-04-18 Pedro Alves <palves@redhat.com>
* Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
unittests/optional-selftests.c.
(SUBDIR_UNITTESTS_OBS): Add optional-selftests.o.
* unittests/optional-selftests.c: New file.
* unittests/optional/assignment/1.cc: New file.
* unittests/optional/assignment/2.cc: New file.
* unittests/optional/assignment/3.cc: New file.
* unittests/optional/assignment/4.cc: New file.
* unittests/optional/assignment/5.cc: New file.
* unittests/optional/assignment/6.cc: New file.
* unittests/optional/assignment/7.cc: New file.
* unittests/optional/cons/copy.cc: New file.
* unittests/optional/cons/default.cc: New file.
* unittests/optional/cons/move.cc: New file.
* unittests/optional/cons/value.cc: New file.
* unittests/optional/in_place.cc: New file.
* unittests/optional/observers/1.cc: New file.
* unittests/optional/observers/2.cc: New file.
Diffstat (limited to 'gdb/Makefile.in')
| -rw-r--r-- | gdb/Makefile.in | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/gdb/Makefile.in b/gdb/Makefile.in index 291b1a0..ed4f58a 100644 --- a/gdb/Makefile.in +++ b/gdb/Makefile.in @@ -526,12 +526,14 @@ SUBDIR_PYTHON_CFLAGS = SUBDIR_UNITTESTS_SRCS = \ unittests/function-view-selftests.c \ unittests/offset-type-selftests.c \ - unittests/ptid-selftests.c + unittests/ptid-selftests.c \ + unittests/optional-selftests.c SUBDIR_UNITTESTS_OBS = \ function-view-selftests.o \ offset-type-selftests.o \ - ptid-selftests.o + ptid-selftests.o \ + optional-selftests.o # Opcodes currently live in one of two places. Either they are in the # opcode library, typically ../opcodes, or they are in a header file |