diff options
| author | Tom Tromey <tromey@redhat.com> | 2013-12-06 11:34:49 -0700 |
|---|---|---|
| committer | Tom Tromey <tromey@redhat.com> | 2013-12-19 08:50:48 -0700 |
| commit | 12e8c7d7c2af309b8fd6bf0f61e99b0a6aad4c80 (patch) | |
| tree | e0dffbb79fb883c98ebbcac865ab686ca74d36cf /gdb/ChangeLog | |
| parent | fcd488ca4e57141ac8ad28b6a5f560f3b9753a67 (diff) | |
| download | gdb-12e8c7d7c2af309b8fd6bf0f61e99b0a6aad4c80.zip gdb-12e8c7d7c2af309b8fd6bf0f61e99b0a6aad4c80.tar.gz gdb-12e8c7d7c2af309b8fd6bf0f61e99b0a6aad4c80.tar.bz2 | |
don't allocate serial_ops
Now that struct serial_ops is const everywhere, we can easily turn the
instances into globals. This patch implements this idea.
On the one hand I think this is nicer since it makes a bit more data
readonly and slightly reduces allocations. On the other hand it
reduces readability somewhat.
If the readability is a concern to anyone I was thinking I could write
a macro that conditionally uses GCC's designated initializer
extension.
Tested by rebuilding on x86-64 Fedora 18, both natively and using the
mingw cross tools.
2013-12-19 Tom Tromey <tromey@redhat.com>
* ser-unix.c (hardwire_ops): New global.
(_initialize_ser_hardwire): Use it.
* ser-tcp.c (tcp_ops): New global.
(_initialize_ser_tcp): Use it.
* ser-pipe.c (pipe_ops): New global.
(_initialize_ser_pipe): Use it.
* ser-mingw.c (hardwire_ops, tty_ops, pipe_ops, tcp_ops): New
globals.
(_initialize_ser_windows): Use them.
Diffstat (limited to 'gdb/ChangeLog')
| -rw-r--r-- | gdb/ChangeLog | 12 |
1 files changed, 12 insertions, 0 deletions
diff --git a/gdb/ChangeLog b/gdb/ChangeLog index b11726d..374b8c5 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,5 +1,17 @@ 2013-12-19 Tom Tromey <tromey@redhat.com> + * ser-unix.c (hardwire_ops): New global. + (_initialize_ser_hardwire): Use it. + * ser-tcp.c (tcp_ops): New global. + (_initialize_ser_tcp): Use it. + * ser-pipe.c (pipe_ops): New global. + (_initialize_ser_pipe): Use it. + * ser-mingw.c (hardwire_ops, tty_ops, pipe_ops, tcp_ops): New + globals. + (_initialize_ser_windows): Use them. + +2013-12-19 Tom Tromey <tromey@redhat.com> + * serial.c (serial_ops_p): New typedef. (serial_ops_list): Now a VEC. (serial_interface_lookup): Return const. Use VEC_iterate. |