aboutsummaryrefslogtreecommitdiff
path: root/gdb/ChangeLog
diff options
context:
space:
mode:
authorTom Tromey <tom@tromey.com>2018-02-21 10:36:55 -0700
committerTom Tromey <tom@tromey.com>2018-02-26 09:21:08 -0700
commit15ce8941e7d2807a3396a6874c528b24c387660a (patch)
tree4c1cf8a075385ffb4f6a629617ec0753019d7b75 /gdb/ChangeLog
parentd7c798565e0f12a821dd399ac3bbf5d49271169a (diff)
downloadgdb-15ce8941e7d2807a3396a6874c528b24c387660a.zip
gdb-15ce8941e7d2807a3396a6874c528b24c387660a.tar.gz
gdb-15ce8941e7d2807a3396a6874c528b24c387660a.tar.bz2
Sign-extend non-bit-fields in unpack_bits_as_long
unpack_bits_as_long is documented as sign-extending its result when the type is signed. However, it was only doing sign-extension in the case where the field was a bitfield -- that is, not when the "bitsize" parameter was 0, indicating the size should be taken from the type. Also, unpack_bits_as_long was incorrectly computing the shift for big-endian architectures for the non-bitfield case. This patch fixes these bugs in a straightforward way. A new selftest is included. 2018-02-26 Tom Tromey <tom@tromey.com> * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add unittests/unpack-selftests.c. * unittests/unpack-selftests.c: New file. * value.c (unpack_bits_as_long): Fix bugs in non-bitfield cases.
Diffstat (limited to 'gdb/ChangeLog')
-rw-r--r--gdb/ChangeLog7
1 files changed, 7 insertions, 0 deletions
diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index e7dd890..0d01668 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,10 @@
+2018-02-26 Tom Tromey <tom@tromey.com>
+
+ * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
+ unittests/unpack-selftests.c.
+ * unittests/unpack-selftests.c: New file.
+ * value.c (unpack_bits_as_long): Fix bugs in non-bitfield cases.
+
2018-02-26 Yao Qi <yao.qi@linaro.org>
* dwarf2read.c (struct partial_die_info) <read>: New method.