diff options
| author | Andreas Arnez <arnez@linux.vnet.ibm.com> | 2017-06-13 15:20:31 +0200 |
|---|---|---|
| committer | Andreas Arnez <arnez@linux.vnet.ibm.com> | 2017-06-13 15:20:31 +0200 |
| commit | 23f945bf8cebf348154aff43782de2e1977e9230 (patch) | |
| tree | f4117bc4ecbce340ec673335ca084de240bdb969 /gdb/ChangeLog | |
| parent | f236533e3c6a2693bea879b2a4d24d1229864ac9 (diff) | |
| download | gdb-23f945bf8cebf348154aff43782de2e1977e9230.zip gdb-23f945bf8cebf348154aff43782de2e1977e9230.tar.gz gdb-23f945bf8cebf348154aff43782de2e1977e9230.tar.bz2 | |
Fix bit-/byte-offset mismatch in parameter to read_value_memory
The function read_value_memory accepts a parameter embedded_offset and
expects it to represent the byte offset into the given value. However,
the only invocation with a possibly non-zero embedded_offset happens in
read_pieced_value, where a bit offset is passed instead.
Adjust the implementation of read_value_memory to meet the caller's
expectation. This implicitly fixes the invocation in read_pieced_value.
gdb/ChangeLog:
* valops.c (read_value_memory): Change embedded_offset to
represent a bit offset instead of a byte offset.
* value.h (read_value_memory): Adjust comment.
Diffstat (limited to 'gdb/ChangeLog')
| -rw-r--r-- | gdb/ChangeLog | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 6ca4b5c..b4a9943 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,5 +1,11 @@ 2017-06-13 Andreas Arnez <arnez@linux.vnet.ibm.com> + * valops.c (read_value_memory): Change embedded_offset to + represent a bit offset instead of a byte offset. + * value.h (read_value_memory): Adjust comment. + +2017-06-13 Andreas Arnez <arnez@linux.vnet.ibm.com> + * dwarf2loc.c (read_pieced_value): Remove unnecessary variables dest_offset_bits and source_offset_bits. (write_pieced_value): Likewise. |