diff options
| author | Tom Tromey <tromey@redhat.com> | 2014-01-22 08:52:15 -0700 |
|---|---|---|
| committer | Tom Tromey <tromey@redhat.com> | 2014-01-23 08:03:52 -0700 |
| commit | 83b645b833a4c137441b2ba1c03206371b28c9db (patch) | |
| tree | 7f973cdbe3487cbfed37f55d40d432136ce9d19c /gdb/ChangeLog | |
| parent | 0740f8d82dd18e48d1531c8d86b531341fc9e099 (diff) | |
| download | gdb-83b645b833a4c137441b2ba1c03206371b28c9db.zip gdb-83b645b833a4c137441b2ba1c03206371b28c9db.tar.gz gdb-83b645b833a4c137441b2ba1c03206371b28c9db.tar.bz2 | |
avoid python exception in FrameDecorator.py
This fixes a bug in FrameDecorator.py.
FrameVars seems to assume that Frame.block can return None if there is
no block. However, it actually throws an exception.
I saw this bug while developing a frame filter, but unfortunately I
don't know how to reproduce it. It seems to me that the SAL tests in
_is_limited_frame should exclude the bad cases; and in my attempts to
write a test they do.
Nevertheless I think the fix is reasonably obvious and ought to go in.
2014-01-23 Tom Tromey <tromey@redhat.com>
PR python/16485:
* python/lib/gdb/FrameDecorator.py: (FrameVars.fetch_frame_args):
Handle exception from frame.block.
(FrameVars.fetch_frame_locals): Likewise.
Diffstat (limited to 'gdb/ChangeLog')
| -rw-r--r-- | gdb/ChangeLog | 7 |
1 files changed, 7 insertions, 0 deletions
diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 2e09ef6..b4acab8 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,5 +1,12 @@ 2014-01-23 Tom Tromey <tromey@redhat.com> + PR python/16485: + * python/lib/gdb/FrameDecorator.py: (FrameVars.fetch_frame_args): + Handle exception from frame.block. + (FrameVars.fetch_frame_locals): Likewise. + +2014-01-23 Tom Tromey <tromey@redhat.com> + PR python/16487: * python/py-framefilter.c (py_print_frame): Don't call Py_DECREF on a NULL pointer. Move "goto error" to correct place. |