diff options
| author | Pedro Alves <palves@redhat.com> | 2013-04-19 15:27:06 +0000 |
|---|---|---|
| committer | Pedro Alves <palves@redhat.com> | 2013-04-19 15:27:06 +0000 |
| commit | bc20a4afc3fa41cab07aa68571b713ecef0aa675 (patch) | |
| tree | 241fb2ef1f6c8643a0af164ddf4df0490e9134d9 /gdb/ChangeLog | |
| parent | c628b528e091211bd746e5c9b18b5bc7298d01f3 (diff) | |
| download | gdb-bc20a4afc3fa41cab07aa68571b713ecef0aa675.zip gdb-bc20a4afc3fa41cab07aa68571b713ecef0aa675.tar.gz gdb-bc20a4afc3fa41cab07aa68571b713ecef0aa675.tar.bz2 | |
gdb_byte for binary buffer, char for string: remote.c, tracepoint.c.
While the RSP is largely ASCII based (hence the packet buffer type is
char *), at places we pass around 8-bit binary packets in that buffer.
Functions like hex2bin or remote_escape_output conceptually are
handling binary buffers, so I left them as working with gdb_byte, and
added casts where necessary. Whether these are host bytes or target
bytes is blurry at present, so this is largely a matter of taste.
Switching some of these functions to take "char *" or "void *" would
be equally good.
gdb/
2013-04-19 Pedro Alves <palves@redhat.com>
* remote.c (remote_write_bytes_aux, compare_sections_command)
(remote_read_qxfer)
(remote_search_memory, remote_hostio_pwrite, remote_hostio_pread)
(remote_hostio_readlink, remote_bfd_iovec_pread)
(remote_set_trace_notes): Use gdb_byte when RSP buffer is used as
binary buffer, and char when buffer is used as string.
* tracepoint.c (encode_source_string, tfile_write_uploaded_tp)
(trace_save, tfile_open, traceframe_walk_blocks)
(tfile_fetch_registers): Likewise.
Diffstat (limited to 'gdb/ChangeLog')
| -rw-r--r-- | gdb/ChangeLog | 12 |
1 files changed, 12 insertions, 0 deletions
diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 49448b6..8b3bfbd 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,5 +1,17 @@ 2013-04-19 Pedro Alves <palves@redhat.com> + * remote.c (remote_write_bytes_aux, compare_sections_command) + (remote_read_qxfer) + (remote_search_memory, remote_hostio_pwrite, remote_hostio_pread) + (remote_hostio_readlink, remote_bfd_iovec_pread) + (remote_set_trace_notes): Use gdb_byte when RSP buffer is used as + binary buffer, and char when buffer is used as string. + * tracepoint.c (encode_source_string, tfile_write_uploaded_tp) + (trace_save, tfile_open, traceframe_walk_blocks) + (tfile_fetch_registers): Likewise. + +2013-04-19 Pedro Alves <palves@redhat.com> + * ser-base.c (ser_base_write): Change prototype -- take 'void *' buffer and size_t size. Adjust. * ser-base.h (ser_base_write): Adjust. |