diff options
| author | Tom Tromey <tromey@adacore.com> | 2019-05-01 11:13:31 -0600 |
|---|---|---|
| committer | Tom Tromey <tromey@adacore.com> | 2019-05-08 10:32:09 -0600 |
| commit | 99f20f08682ecc7be882774ff78409530802d000 (patch) | |
| tree | 90335855e5d39c61fd09f5a5b40aef30b39be386 /gdb/ChangeLog | |
| parent | 80e55b132940813fa454da2592a31db6c8af85f1 (diff) | |
| download | gdb-99f20f08682ecc7be882774ff78409530802d000.zip gdb-99f20f08682ecc7be882774ff78409530802d000.tar.gz gdb-99f20f08682ecc7be882774ff78409530802d000.tar.bz2 | |
Fix style bug when paging
Philippe pointed out a styling bug that would occur in some conditions
when paging:
https://sourceware.org/ml/gdb-patches/2019-04/msg00101.html
I was finally able to reproduce this, and this patch fixes the bug.
The problem occurred when text overflowed the line, causing a
pagination prompt, but when no wrap column had been set. In this
case, the current style was reset to show the prompt, but then not
reset back to the previously applied style before emitting the rest of
the line.
The fix is to record the applied style in this case, and re-apply it
afterward -- but only if the pager prompt was emitted, something that
the existing style.exp pointed out on the first, more naive, version
of the patch.
Tested on x86-64 Fedora 29.
gdb/ChangeLog
2019-05-08 Tom Tromey <tromey@adacore.com>
* utils.c (fputs_maybe_filtered): Reset style after paging, even
when no wrap column is set.
Diffstat (limited to 'gdb/ChangeLog')
| -rw-r--r-- | gdb/ChangeLog | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 2d723cb..ca20a7c 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,5 +1,10 @@ 2019-05-08 Tom Tromey <tromey@adacore.com> + * utils.c (fputs_maybe_filtered): Reset style after paging, even + when no wrap column is set. + +2019-05-08 Tom Tromey <tromey@adacore.com> + * c-lang.c (c_get_string): Handle non-C-style arrays. 2019-05-08 Tom Tromey <tromey@adacore.com> |