diff options
author | Joel Brobecker <brobecker@gnat.com> | 2012-08-16 23:55:02 +0000 |
---|---|---|
committer | Joel Brobecker <brobecker@gnat.com> | 2012-08-16 23:55:02 +0000 |
commit | 973e3cf70d3a47d0093916dbe8459bee2e5f41cb (patch) | |
tree | e4958df1f656f8314846b9bed87acab030239195 /gdb/ChangeLog | |
parent | d80ee84fe21876c78f66e60b70e335e8dab99d07 (diff) | |
download | gdb-973e3cf70d3a47d0093916dbe8459bee2e5f41cb.zip gdb-973e3cf70d3a47d0093916dbe8459bee2e5f41cb.tar.gz gdb-973e3cf70d3a47d0093916dbe8459bee2e5f41cb.tar.bz2 |
fix internal_error during fork event handling.
When running on ia64-hpux a program that calls fork, GDB currently
reports the following internal error:
internal-error: Can't determine the current address space of thread process 1882
Here is what happens:
1. GDB receives a "fork" event;
2. handle_inferior_event calls detach_breakpoints for the child process;
3. detach_breakpoints calls ia64's gdbarch remove_breakpoint hook,
which needs to read an entire instruction slot in order to remove
a breakpoint instruction from memory;
4. To read inferior memory, the ia64-hpux code needs to know where
that memory is located relative to the bsp..bspstore area,
and thus needs to read the value of those registers;
5. To get the value of those registers, ia64_hpux_xfer_memory current
uses the current regcache.
The problem is that at the time we are trying to remove the breakpoints
from the child, the child process is not part of the list of inferiors
really known to GDB (it has not been added to inferior_list), so trying
to create a regcache for it triggers an internal error when creating
address space for the regcache (as the address space is ultimately
fetched from the inferior).
To work around this limitation, ia64_hpux_xfer_memory has been modified
to detect the fact the current inferior is not in our inferior list,
and to go, in that case, straight to the source to fetch the registers
it needs.
gdb/ChangeLog:
* ia64-hpux-nat.c (ia64_hpux_get_register_from_save_state_t):
New function.
(ia64_hpux_xfer_memory): Check if inferior_ptid is known before
using the regache. Use ia64_hpux_get_register_from_save_state_t
to access the bsp and bspstore registers if not.
Diffstat (limited to 'gdb/ChangeLog')
-rw-r--r-- | gdb/ChangeLog | 8 |
1 files changed, 8 insertions, 0 deletions
diff --git a/gdb/ChangeLog b/gdb/ChangeLog index f52139f..ec0532e 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,5 +1,13 @@ 2012-08-16 Joel Brobecker <brobecker@adacore.com> + * ia64-hpux-nat.c (ia64_hpux_get_register_from_save_state_t): + New function. + (ia64_hpux_xfer_memory): Check if inferior_ptid is known before + using the regache. Use ia64_hpux_get_register_from_save_state_t + to access the bsp and bspstore registers if not. + +2012-08-16 Joel Brobecker <brobecker@adacore.com> + * breakpoint.h (detach_breakpoints): pid parameter is now a ptid. * breakpoint.c (detach_breakpoints): Change pid parameter into a ptid. Adjust code accordingly. |