diff options
| author | Joel Brobecker <brobecker@gnat.com> | 2010-09-22 22:50:54 +0000 |
|---|---|---|
| committer | Joel Brobecker <brobecker@gnat.com> | 2010-09-22 22:50:54 +0000 |
| commit | 39383a48f726a69d632f4899acaccb0ba5f5a61b (patch) | |
| tree | 272bf33c9328a6481c46003b93861ec387f1d340 /gdb/ChangeLog | |
| parent | 7a360e83fc3bfe89586d408f2107242c85a0daf8 (diff) | |
| download | gdb-39383a48f726a69d632f4899acaccb0ba5f5a61b.zip gdb-39383a48f726a69d632f4899acaccb0ba5f5a61b.tar.gz gdb-39383a48f726a69d632f4899acaccb0ba5f5a61b.tar.bz2 | |
[Ada] Do not compute task ptid when debugging core file
After thread support over core files was added for GNU/Linux was added,
we started noticing the following type of crash when trying to perform
task switches (this is a bit accademic, since task switching is not
supported when debugging core files - this is what our testcase was
verifying).
(please check out the comment inside ada-tasks.c:task_command for
more details on this topic)
The reason for the crash comes from the fact that the GNU/Linux thread
layer now gets pushed on the target stack, causing the associated
to_get_ada_task_ptid target method to be activated. This routine
makes the assumption that, for all threads, the private area is not
NULL. This is incorrect in the case of core files, as the core layer
creates some threads with no private data.
But, taking a step back, we don't need to try to compute the task ptid,
as we'll never be using it anyways (we only use it for task switching).
So the fix is to avoid the ptid computation altogether when debugging
a core file.
gdb/ChangeLog:
* ada-tasks.c (read_atcb): Do not compute the task ptid when
debugging a core file.
Diffstat (limited to 'gdb/ChangeLog')
| -rw-r--r-- | gdb/ChangeLog | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 9f959c1..4b1b74e 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,8 @@ +2010-09-22 Joel Brobecker <brobecker@adacore.com> + + * ada-tasks.c (read_atcb): Do not compute the task ptid when + debugging a core file. + 2010-09-22 Jan Kratochvil <jan.kratochvil@redhat.com> Code cleanup. |