diff options
| author | Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE> | 2020-06-21 18:51:58 +0200 |
|---|---|---|
| committer | Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE> | 2020-06-21 18:51:58 +0200 |
| commit | 196535a69c8568342e62fdf5e3f5ade04470fd6a (patch) | |
| tree | 6eeace8b5bccc8a58ea632f6f38562155098867c /gdb/ChangeLog | |
| parent | cf6f3e86ded2cd950f59a0f2c164f2c953ef534b (diff) | |
| download | gdb-196535a69c8568342e62fdf5e3f5ade04470fd6a.zip gdb-196535a69c8568342e62fdf5e3f5ade04470fd6a.tar.gz gdb-196535a69c8568342e62fdf5e3f5ade04470fd6a.tar.bz2 | |
Various procfs.c cleanups
While reading through procfs.c, I noticed a couple of cleanup
opportunities:
* Some comments and code allowed for portability across different
targets. Since procfs.c is Solaris-only for some time now, those can
go.
* Likewise, there were some references to the old ioctl-based /proc left.
* The code still allowed for SYS_exec. However, it is no longer present
in either Solaris 11.3, 11.4, or Illumos. Checking the OpenSolaris
sources, I found that it had already been removed in 2010 well before
the Solaris 11 release.
* Some blocks of #if 0 code can go:
** References to struct procinfo.{g,fp}regs_dirty which are no longer
defined.
** Code handling the PR_ASLWP flag where <sys/procfs.h> has
#define PR_ASLWP 0x00000040 /* obsolete flag; never set */
Tested on amd64-pc-solaris2.11.
* procfs.c: Cleanup many comments.
(READ_WATCHFLAG, WRITE_WATCHFLAG, EXEC_WATCHFLAG)
(AFTER_WATCHFLAG): Replace by value.
(MAIN_PROC_NAME_FORMAT): Inline ...
(create_procinfo): ... here.
(procfs_debug_inferior): Remove SYS_exec handling.
(syscall_is_exec): Likewise.
(procfs_set_exec_trap): Likewise.
(syscall_is_lwp_exit): Inline in callers.
(syscall_is_exit): Likewise.
(syscall_is_exec): Likewise.
(syscall_is_lwp_create): Likewise.
(invalidate_cache): Remove #if 0 code.
(make_signal_thread_runnable): Remove.
(procfs_target::resume): Remove #if 0 code.
Diffstat (limited to 'gdb/ChangeLog')
| -rw-r--r-- | gdb/ChangeLog | 24 |
1 files changed, 24 insertions, 0 deletions
diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 1f614d5..565a71a 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,5 +1,29 @@ 2020-06-21 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE> + * procfs.c: Cleanup many comments. + + (READ_WATCHFLAG, WRITE_WATCHFLAG, EXEC_WATCHFLAG) + (AFTER_WATCHFLAG): Replace by value. + + (MAIN_PROC_NAME_FORMAT): Inline ... + (create_procinfo): ... here. + + (procfs_debug_inferior): Remove SYS_exec handling. + (syscall_is_exec): Likewise. + (procfs_set_exec_trap): Likewise. + + (syscall_is_lwp_exit): Inline in callers. + (syscall_is_exit): Likewise. + (syscall_is_exec): Likewise. + (syscall_is_lwp_create): Likewise. + + (invalidate_cache): Remove #if 0 code. + + (make_signal_thread_runnable): Remove. + (procfs_target::resume): Remove #if 0 code. + +2020-06-21 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE> + PR gdb/25939 * procfs.c (procfs_target::procfs_init_inferior): Move push_target call ... |