aboutsummaryrefslogtreecommitdiff
path: root/gas
diff options
context:
space:
mode:
authorTamar Christina <tamar.christina@arm.com>2018-06-07 11:53:13 +0100
committerTamar Christina <tamar.christina@arm.com>2018-06-07 11:54:11 +0100
commit2a9b2c1abe29e1063240604d2464b8de9a46011f (patch)
treec522d8fbc38066701367b25f7ed792b72849da57 /gas
parent63bad7b636870e3a0af4fc97cc2b8ec5c2603a41 (diff)
downloadgdb-2a9b2c1abe29e1063240604d2464b8de9a46011f.zip
gdb-2a9b2c1abe29e1063240604d2464b8de9a46011f.tar.gz
gdb-2a9b2c1abe29e1063240604d2464b8de9a46011f.tar.bz2
Fix AArch64 unintialized variable which can cause diagnostic failures.
This patch fixes an uninitialized memory issue that can under certain circumstances turn an error into a warning because non_fatal was not initialised in all cases. Verified using valgrind. gas/config/tc-aarch64.c PR binutils/21446 * tc-aarch64.c (record_operand_error, record_operand_error_with_data): Initialize non_fatal.
Diffstat (limited to 'gas')
-rw-r--r--gas/ChangeLog6
-rw-r--r--gas/config/tc-aarch64.c2
2 files changed, 8 insertions, 0 deletions
diff --git a/gas/ChangeLog b/gas/ChangeLog
index 0beb5b5..ac392b9 100644
--- a/gas/ChangeLog
+++ b/gas/ChangeLog
@@ -1,3 +1,9 @@
+2018-06-08 Tamar Christina <tamar.christina@arm.com>
+
+ PR binutils/21446
+ * tc-aarch64.c (record_operand_error, record_operand_error_with_data):
+ Initialize non_fatal.
+
2018-06-06 Sameera Deshpande <sameera.deshpande@linaro.org>
* config/tc-aarch64.c (aarch64_cpus): Add support of ARMv8.4 in
diff --git a/gas/config/tc-aarch64.c b/gas/config/tc-aarch64.c
index 1990cbe..47ca0c8 100644
--- a/gas/config/tc-aarch64.c
+++ b/gas/config/tc-aarch64.c
@@ -4400,6 +4400,7 @@ record_operand_error (const aarch64_opcode *opcode, int idx,
info.index = idx;
info.kind = kind;
info.error = error;
+ info.non_fatal = FALSE;
record_operand_error_info (opcode, &info);
}
@@ -4415,6 +4416,7 @@ record_operand_error_with_data (const aarch64_opcode *opcode, int idx,
info.data[0] = extra_data[0];
info.data[1] = extra_data[1];
info.data[2] = extra_data[2];
+ info.non_fatal = FALSE;
record_operand_error_info (opcode, &info);
}