Tidy elf_symbol_from

bfd/
	* elf-bfd.h (elf_symbol_from): Remove unused ABFD parameter.
	* elf.c (ignore_section_sym, _bfd_elf_copy_private_symbol_data),
	(swap_out_syms): Adjust elf_symbol_from invocation.
binutils/
	* nm.c (print_symbol): Adjust elf_symbol_from invocation.
	* objcopy.c (is_hidden_symbol): Likewise.
gas/
	* config/obj-elf.c (obj_elf_visibility, elf_frob_symbol): Adjust
	elf_symbol_from invocation.
	* config/tc-aarch64.c (s_variant_pcs): Likewise.
	* config/tc-m68hc11.c (s_m68hc11_mark_symbol): Likewise.
	* config/tc-ppc.c (ppc_elf_localentry, ppc_force_relocation),
	(ppc_fix_adjustable): Likewise.
	* config/tc-xgate.c (xgate_frob_symbol): Likewise.
ld/
	* plugin.c (asymbol_from_plugin_symbol): Adjust elf_symbol_from
	invocation.
opcodes/
	* ppc-dis.c (ppc_symbol_is_valid): Adjust elf_symbol_from invocation.

6 files changed, 18 insertions, 11 deletions

diff --git a/gas/ChangeLog b/gas/ChangeLog
index 71e4e8b..4852d4a 100644
--- a/gas/ChangeLog
+++ b/gas/ChangeLog
@@ -1,3 +1,13 @@
+2020-09-16  Alan Modra  <amodra@gmail.com>
+
+	* config/obj-elf.c (obj_elf_visibility, elf_frob_symbol): Adjust
+	elf_symbol_from invocation.
+	* config/tc-aarch64.c (s_variant_pcs): Likewise.
+	* config/tc-m68hc11.c (s_m68hc11_mark_symbol): Likewise.
+	* config/tc-ppc.c (ppc_elf_localentry, ppc_force_relocation),
+	(ppc_fix_adjustable): Likewise.
+	* config/tc-xgate.c (xgate_frob_symbol): Likewise.
+
 2020-09-15  H.J. Lu  <hongjiu.lu@intel.com>
 
 	* testsuite/gas/cfi/reloc-pe-i386.d: Updated.
diff --git a/gas/config/obj-elf.c b/gas/config/obj-elf.c
index 9e39707..b1c9902 100644
--- a/gas/config/obj-elf.c
+++ b/gas/config/obj-elf.c
@@ -482,7 +482,7 @@ obj_elf_visibility (int visibility)
       symbolP = get_sym_from_input_line_and_check ();
 
       bfdsym = symbol_get_bfdsym (symbolP);
-      elfsym = elf_symbol_from (bfd_asymbol_bfd (bfdsym), bfdsym);
+      elfsym = elf_symbol_from (bfdsym);
 
       gas_assert (elfsym);
 
@@ -2565,8 +2565,7 @@ elf_frob_symbol (symbolS *symp, int *puntp)
 	      break;
 	    case visibility_hidden:
 	      bfdsym = symbol_get_bfdsym (symp);
-	      elfsym = elf_symbol_from (bfd_asymbol_bfd (bfdsym),
-					bfdsym);
+	      elfsym = elf_symbol_from (bfdsym);
 	      elfsym->internal_elf_sym.st_other &= ~3;
 	      elfsym->internal_elf_sym.st_other |= STV_HIDDEN;
 	      break;
diff --git a/gas/config/tc-aarch64.c b/gas/config/tc-aarch64.c
index 391746e..57a2b4e 100644
--- a/gas/config/tc-aarch64.c
+++ b/gas/config/tc-aarch64.c
@@ -2001,7 +2001,7 @@ s_variant_pcs (int ignored ATTRIBUTE_UNUSED)
   restore_line_pointer (c);
   demand_empty_rest_of_line ();
   bfdsym = symbol_get_bfdsym (sym);
-  elfsym = elf_symbol_from (bfd_asymbol_bfd (bfdsym), bfdsym);
+  elfsym = elf_symbol_from (bfdsym);
   gas_assert (elfsym);
   elfsym->internal_elf_sym.st_other |= STO_AARCH64_VARIANT_PCS;
 }
diff --git a/gas/config/tc-m68hc11.c b/gas/config/tc-m68hc11.c
index 5735ff8..11cb6cd 100644
--- a/gas/config/tc-m68hc11.c
+++ b/gas/config/tc-m68hc11.c
@@ -3766,7 +3766,7 @@ s_m68hc11_mark_symbol (int mark)
       SKIP_WHITESPACE ();
 
       bfdsym = symbol_get_bfdsym (symbolP);
-      elfsym = elf_symbol_from (bfd_asymbol_bfd (bfdsym), bfdsym);
+      elfsym = elf_symbol_from (bfdsym);
 
       gas_assert (elfsym);
 
diff --git a/gas/config/tc-ppc.c b/gas/config/tc-ppc.c
index 4418182..b26760d 100644
--- a/gas/config/tc-ppc.c
+++ b/gas/config/tc-ppc.c
@@ -2464,7 +2464,7 @@ ppc_elf_localentry (int ignore ATTRIBUTE_UNUSED)
       if (ok)
 	{
 	  bfdsym = symbol_get_bfdsym (sym);
-	  elfsym = elf_symbol_from (bfd_asymbol_bfd (bfdsym), bfdsym);
+	  elfsym = elf_symbol_from (bfdsym);
 	  gas_assert (elfsym);
 	  elfsym->internal_elf_sym.st_other &= ~STO_PPC64_LOCAL_MASK;
 	  elfsym->internal_elf_sym.st_other |= encoded;
@@ -6161,8 +6161,7 @@ ppc_force_relocation (fixS *fix)
       if (fix->fx_addsy)
 	{
 	  asymbol *bfdsym = symbol_get_bfdsym (fix->fx_addsy);
-	  elf_symbol_type *elfsym
-	    = elf_symbol_from (bfd_asymbol_bfd (bfdsym), bfdsym);
+	  elf_symbol_type *elfsym = elf_symbol_from (bfdsym);
 	  gas_assert (elfsym);
 	  if ((STO_PPC64_LOCAL_MASK & elfsym->internal_elf_sym.st_other) != 0)
 	    return 1;
@@ -6198,8 +6197,7 @@ ppc_fix_adjustable (fixS *fix)
       if (fix->fx_addsy)
 	{
 	  asymbol *bfdsym = symbol_get_bfdsym (fix->fx_addsy);
-	  elf_symbol_type *elfsym
-	    = elf_symbol_from (bfd_asymbol_bfd (bfdsym), bfdsym);
+	  elf_symbol_type *elfsym = elf_symbol_from (bfdsym);
 	  gas_assert (elfsym);
 	  if ((STO_PPC64_LOCAL_MASK & elfsym->internal_elf_sym.st_other) != 0)
 	    return 0;
diff --git a/gas/config/tc-xgate.c b/gas/config/tc-xgate.c
index b936865..646be64 100644
--- a/gas/config/tc-xgate.c
+++ b/gas/config/tc-xgate.c
@@ -1007,7 +1007,7 @@ xgate_frob_symbol (symbolS *sym)
   elf_symbol_type *elfsym;
 
   bfdsym = symbol_get_bfdsym (sym);
-  elfsym = elf_symbol_from (bfd_asymbol_bfd (bfdsym), bfdsym);
+  elfsym = elf_symbol_from (bfdsym);
 
   gas_assert (elfsym);