diff options
| author | Richard Sandiford <richard.sandiford@arm.com> | 2016-06-15 15:30:31 +0100 |
|---|---|---|
| committer | Richard Sandiford <richard.sandiford@arm.com> | 2016-08-23 09:41:02 +0100 |
| commit | 10b362d05ee1849915dd33534eae201697bce957 (patch) | |
| tree | b401e09643a1845f0513a3d0c247be55492b849d /gas | |
| parent | 2167a76c677996c912bacef24d17fdb905856a3f (diff) | |
| download | gdb-10b362d05ee1849915dd33534eae201697bce957.zip gdb-10b362d05ee1849915dd33534eae201697bce957.tar.gz gdb-10b362d05ee1849915dd33534eae201697bce957.tar.bz2 | |
[AArch64][SVE 10/32] Move range check out of parse_aarch64_imm_float
Since some SVE constants are no longer explicitly tied to the 8-bit
FP immediate format, it seems better to move the range checks out of
parse_aarch64_imm_float and into the callers.
gas/
* config/tc-aarch64.c (parse_aarch64_imm_float): Remove range check.
(parse_operands): Check the range of 8-bit FP immediates here instead.
Change-Id: I5cbffb01f84e23f85b2899f2fde7e9b341bcbbf9
Diffstat (limited to 'gas')
| -rw-r--r-- | gas/config/tc-aarch64.c | 14 |
1 files changed, 6 insertions, 8 deletions
diff --git a/gas/config/tc-aarch64.c b/gas/config/tc-aarch64.c index 388c4bf..2489d5b 100644 --- a/gas/config/tc-aarch64.c +++ b/gas/config/tc-aarch64.c @@ -2148,7 +2148,8 @@ can_convert_double_to_float (uint64_t imm, uint32_t *fpword) hexadecimal representation is involved). REG_TYPE says which register names should be treated as registers rather than as symbolic immediates. - N.B. 0.0 is accepted by this function. */ + This routine accepts any IEEE float; it is up to the callers to reject + invalid ones. */ static bfd_boolean parse_aarch64_imm_float (char **ccp, int *immed, bfd_boolean dp_p, @@ -2224,12 +2225,9 @@ parse_aarch64_imm_float (char **ccp, int *immed, bfd_boolean dp_p, } } - if (aarch64_imm_float_p (fpword) || fpword == 0) - { - *immed = fpword; - *ccp = str; - return TRUE; - } + *immed = fpword; + *ccp = str; + return TRUE; invalid_fp: set_fatal_syntax_error (_("invalid floating-point constant")); @@ -5296,7 +5294,7 @@ parse_operands (char *str, const aarch64_opcode *opcode) = (aarch64_get_qualifier_esize (inst.base.operands[0].qualifier) == 8); if (!parse_aarch64_imm_float (&str, &qfloat, dp_p, imm_reg_type) - || qfloat == 0) + || !aarch64_imm_float_p (qfloat)) { if (!error_p ()) set_fatal_syntax_error (_("invalid floating-point" |