diff options
| author | Maciej W. Rozycki <macro@linux-mips.org> | 2018-09-20 15:49:00 +0100 |
|---|---|---|
| committer | Maciej W. Rozycki <macro@linux-mips.org> | 2018-09-20 15:49:00 +0100 |
| commit | 53b6d6f5b2d8681cc4a061e05fe28ef896900908 (patch) | |
| tree | e0b27cf753b9a1e074ec63f1b02d731462372ab2 /gas | |
| parent | ed3162adc45291b3de496be25911ebfd39f43a36 (diff) | |
| download | gdb-53b6d6f5b2d8681cc4a061e05fe28ef896900908.zip gdb-53b6d6f5b2d8681cc4a061e05fe28ef896900908.tar.gz gdb-53b6d6f5b2d8681cc4a061e05fe28ef896900908.tar.bz2 | |
ARC: Fix build errors with large constants and C89
Fix build errors:
cc1: warnings being treated as errors
In file included from .../opcodes/arc-opc.c:2630:
.../opcodes/arc-nps400-tbl.h:38: warning: integer constant is too large for 'long' type
.../opcodes/arc-nps400-tbl.h:38: warning: integer constant is too large for 'long' type
.../opcodes/arc-nps400-tbl.h:41: warning: integer constant is too large for 'long' type
.../opcodes/arc-nps400-tbl.h:41: warning: integer constant is too large for 'long' type
[...]
.../opcodes/arc-nps400-tbl.h:712: warning: integer constant is too large for 'long' type
.../opcodes/arc-nps400-tbl.h:712: warning: integer constant is too large for 'long' type
.../opcodes/arc-nps400-tbl.h:715: warning: integer constant is too large for 'long' type
.../opcodes/arc-nps400-tbl.h:715: warning: integer constant is too large for 'long' type
make[4]: *** [arc-opc.lo] Error 1
and:
cc1: warnings being treated as errors
.../gas/config/tc-arc.c: In function 'md_number_to_chars_midend':
.../gas/config/tc-arc.c:802: warning: integer constant is too large for 'long' type
.../gas/config/tc-arc.c:810: warning: integer constant is too large for 'long' type
make[4]: *** [config/tc-arc.o] Error 1
observed with GCC 4.1.2 and presumably other C89 compilers with the
`arc-elf' and `arc-linux-gnu' targets, caused by the use of constants
the values of which are outside the range of the `int' type (or the
`long' type if it is of the same with). In the C89 language standard
such constants are not implicitly converted to a wider type and an
explicit suffix is required for such constants.
Add a `ull' suffix then as with such constants used in other ports.
gas/
* config/tc-arc.c (md_number_to_chars_midend): Append `ull' to
large constants.
opcodes/
* arc-nps400-tbl.h: Append `ull' to large constants throughout.
Diffstat (limited to 'gas')
| -rw-r--r-- | gas/ChangeLog | 5 | ||||
| -rw-r--r-- | gas/config/tc-arc.c | 4 |
2 files changed, 7 insertions, 2 deletions
diff --git a/gas/ChangeLog b/gas/ChangeLog index d495233e..47e1f7a 100644 --- a/gas/ChangeLog +++ b/gas/ChangeLog @@ -1,3 +1,8 @@ +2018-09-20 Maciej W. Rozycki <macro@linux-mips.org> + + * config/tc-arc.c (md_number_to_chars_midend): Append `ull' to + large constants. + 2018-09-20 Nelson Chu <nelson.chu1990@gmail.com> * config/tc-nds32.c: Remove the unused target features. diff --git a/gas/config/tc-arc.c b/gas/config/tc-arc.c index 6f0407b..a9b3f1a 100644 --- a/gas/config/tc-arc.c +++ b/gas/config/tc-arc.c @@ -799,7 +799,7 @@ md_number_to_chars_midend (char *buf, unsigned long long val, int n) md_number_to_chars (buf, val, n); break; case 6: - md_number_to_chars (buf, (val & 0xffff00000000) >> 32, 2); + md_number_to_chars (buf, (val & 0xffff00000000ull) >> 32, 2); md_number_to_chars_midend (buf + 2, (val & 0xffffffff), 4); break; case 4: @@ -807,7 +807,7 @@ md_number_to_chars_midend (char *buf, unsigned long long val, int n) md_number_to_chars (buf + 2, (val & 0xffff), 2); break; case 8: - md_number_to_chars_midend (buf, (val & 0xffffffff00000000) >> 32, 4); + md_number_to_chars_midend (buf, (val & 0xffffffff00000000ull) >> 32, 4); md_number_to_chars_midend (buf + 4, (val & 0xffffffff), 4); break; default: |