diff options
| author | Richard Sandiford <richard.sandiford@arm.com> | 2016-09-21 16:49:07 +0100 |
|---|---|---|
| committer | Richard Sandiford <richard.sandiford@arm.com> | 2016-09-21 16:49:07 +0100 |
| commit | 6a9deabec4faf3160a527d11ab5d6997dec7d66a (patch) | |
| tree | d70086fadec4a964f5e85dc20f174af425fd0e57 /gas/testsuite | |
| parent | 04a3379aceaeb8e29f2586d756d5f2ef26c85e7e (diff) | |
| download | gdb-6a9deabec4faf3160a527d11ab5d6997dec7d66a.zip gdb-6a9deabec4faf3160a527d11ab5d6997dec7d66a.tar.gz gdb-6a9deabec4faf3160a527d11ab5d6997dec7d66a.tar.bz2 | |
[AArch64][SVE 09/32] Improve error messages for invalid floats
Previously:
fmov d0, #2
would give an error:
Operand 2 should be an integer register
whereas the user probably just forgot to add the ".0" to make:
fmov d0, #2.0
This patch reports an invalid floating point constant unless the
operand is obviously a register.
The FPIMM8 handling is only relevant for SVE. Without it:
fmov z0, z1
would try to parse z1 as an integer immediate zero (the res2 path),
whereas it's more likely that the user forgot the predicate. This is
tested by the final patch.
gas/
* config/tc-aarch64.c (parse_aarch64_imm_float): Report a specific
low-severity error for registers.
(parse_operands): Report an invalid floating point constant for
if parsing an FPIMM8 fails, and if no better error has been
recorded.
* testsuite/gas/aarch64/diagnostic.s,
testsuite/gas/aarch64/diagnostic.l: Add tests for integer operands
to FMOV.
Diffstat (limited to 'gas/testsuite')
| -rw-r--r-- | gas/testsuite/gas/aarch64/diagnostic.l | 4 | ||||
| -rw-r--r-- | gas/testsuite/gas/aarch64/diagnostic.s | 5 |
2 files changed, 9 insertions, 0 deletions
diff --git a/gas/testsuite/gas/aarch64/diagnostic.l b/gas/testsuite/gas/aarch64/diagnostic.l index c278887..67ef484 100644 --- a/gas/testsuite/gas/aarch64/diagnostic.l +++ b/gas/testsuite/gas/aarch64/diagnostic.l @@ -144,3 +144,7 @@ [^:]*:255: Error: register element index out of range 0 to 15 at operand 1 -- `ld2 {v0\.b,v1\.b}\[-1\],\[x0\]' [^:]*:258: Error: register element index out of range 0 to 15 at operand 1 -- `ld2 {v0\.b,v1\.b}\[16\],\[x0\]' [^:]*:259: Error: register element index out of range 0 to 15 at operand 1 -- `ld2 {v0\.b,v1\.b}\[67\],\[x0\]' +[^:]*:261: Error: invalid floating-point constant at operand 2 -- `fmov d0,#2' +[^:]*:262: Error: invalid floating-point constant at operand 2 -- `fmov d0,#-2' +[^:]*:263: Error: invalid floating-point constant at operand 2 -- `fmov s0,2' +[^:]*:264: Error: invalid floating-point constant at operand 2 -- `fmov s0,-2' diff --git a/gas/testsuite/gas/aarch64/diagnostic.s b/gas/testsuite/gas/aarch64/diagnostic.s index ac2eb5c..3092b9b 100644 --- a/gas/testsuite/gas/aarch64/diagnostic.s +++ b/gas/testsuite/gas/aarch64/diagnostic.s @@ -257,3 +257,8 @@ ld2 {v0.b, v1.b}[15], [x0] ld2 {v0.b, v1.b}[16], [x0] ld2 {v0.b, v1.b}[67], [x0] + + fmov d0, #2 + fmov d0, #-2 + fmov s0, 2 + fmov s0, -2 |