diff options
author | Max Filippov <jcmvbkbc@gmail.com> | 2016-02-02 17:11:38 +0300 |
---|---|---|
committer | Max Filippov <jcmvbkbc@gmail.com> | 2016-02-03 20:44:57 +0300 |
commit | ea173078d2c0c1af13a8b315ca187ffa4d00cd66 (patch) | |
tree | 2dff54ce68447dd4d78c34d6f85bc38861770df7 /gas/config | |
parent | 0cb4071ef9e10f703220f5e731141bf438aca16e (diff) | |
download | gdb-ea173078d2c0c1af13a8b315ca187ffa4d00cd66.zip gdb-ea173078d2c0c1af13a8b315ca187ffa4d00cd66.tar.gz gdb-ea173078d2c0c1af13a8b315ca187ffa4d00cd66.tar.bz2 |
xtensa: fix signedness of gas relocations
Change 1058c7532d0b "Use signed data type for R_XTENSA_DIFF* relocation
offsets." changed signedness of BFD_RELOC_XTENSA_DIFF* relocations
substituted for BFD_RELOC_*. This made it impossible to encode arbitrary
8-, 16- and 32-bit values, which broke e.g. debug info encoding by .loc
directive. Revert this part and add test.
gas/
2016-02-03 Max Filippov <jcmvbkbc@gmail.com>
* config/tc-xtensa.c (md_apply_fix): Mark BFD_RELOC_XTENSA_DIFF*
substitutions for BFD_RELOC_* as unsigned.
* gas/testsuite/gas/xtensa/all.exp: Add loc to list of xtensa
tests.
* gas/testsuite/gas/xtensa/loc.d: New file: loc test result
patterns.
* gas/testsuite/gas/xtensa/loc.s: New file: loc test.
Diffstat (limited to 'gas/config')
-rw-r--r-- | gas/config/tc-xtensa.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/gas/config/tc-xtensa.c b/gas/config/tc-xtensa.c index a119871..36a06cc 100644 --- a/gas/config/tc-xtensa.c +++ b/gas/config/tc-xtensa.c @@ -5961,15 +5961,15 @@ md_apply_fix (fixS *fixP, valueT *valP, segT seg) { case BFD_RELOC_8: fixP->fx_r_type = BFD_RELOC_XTENSA_DIFF8; - fixP->fx_signed = 1; + fixP->fx_signed = 0; break; case BFD_RELOC_16: fixP->fx_r_type = BFD_RELOC_XTENSA_DIFF16; - fixP->fx_signed = 1; + fixP->fx_signed = 0; break; case BFD_RELOC_32: fixP->fx_r_type = BFD_RELOC_XTENSA_DIFF32; - fixP->fx_signed = 1; + fixP->fx_signed = 0; break; default: break; |