diff options
| author | Max Filippov <jcmvbkbc@gmail.com> | 2014-04-15 19:12:46 +0400 |
|---|---|---|
| committer | Max Filippov <jcmvbkbc@gmail.com> | 2014-04-22 22:53:49 +0400 |
| commit | a35d5e823fdfe8a6e7e05ca8e3fb8bb5697335b1 (patch) | |
| tree | f6c54cb44c457093f199a20d9bcf1a37a33f32ab /gas/config | |
| parent | 483805cf9ea5a6dace41415d8830e93fccc49c43 (diff) | |
| download | gdb-a35d5e823fdfe8a6e7e05ca8e3fb8bb5697335b1.zip gdb-a35d5e823fdfe8a6e7e05ca8e3fb8bb5697335b1.tar.gz gdb-a35d5e823fdfe8a6e7e05ca8e3fb8bb5697335b1.tar.bz2 | |
Fix alignment for the first section frag on xtensa
Linking object files produced by partial linking with link-time
relaxation enabled sometimes fails with the following error message:
dangerous relocation: call8: misaligned call target: (.text.unlikely+0x63)
This happens because no basic block with an XTENSA_PROP_ALIGN flag in the
property table is generated for the first basic block, even if the
.align directive is present.
It was believed that the first frag alignment could be derived from the
section alignment, but this was not implemented for the partial linking
case: after partial linking first frag of a section may become not
first, but no additional alignment frag is inserted before it.
Basic block for such frag may be merged with previous basic block into
extended basic block during relaxation pass losing its alignment
restrictions.
Fix this by always recording alignment for the first section frag.
2014-04-22 Max Filippov <jcmvbkbc@gmail.com>
gas/
* config/tc-xtensa.c (xtensa_handle_align): record alignment for the
first section frag.
gas/testsuite/
* gas/xtensa/all.exp: Add test for the first section frag alignment.
* gas/xtensa/first_frag_align.d: First section frag alignment expected
dump.
* gas/xtensa/first_frag_align.s: First section frag alignment test
source.
Diffstat (limited to 'gas/config')
| -rw-r--r-- | gas/config/tc-xtensa.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/gas/config/tc-xtensa.c b/gas/config/tc-xtensa.c index ea23c96..58ace38 100644 --- a/gas/config/tc-xtensa.c +++ b/gas/config/tc-xtensa.c @@ -5609,7 +5609,6 @@ xtensa_handle_align (fragS *fragP) && ! fragP->tc_frag_data.is_literal && (fragP->fr_type == rs_align || fragP->fr_type == rs_align_code) - && fragP->fr_address + fragP->fr_fix > 0 && fragP->fr_offset > 0 && now_seg != bss_section) { |