Use EXIT_SUCCESS and EXIT_FAILURE in all exit calls.

Use exit rather than returning from main, for consistency on VMS.
Call as_fatal instead of as_bad or as_warn followed by exit.

5 files changed, 11 insertions, 19 deletions

diff --git a/gas/config/obj-coff.c b/gas/config/obj-coff.c
index 5891616..960dcfd 100644
--- a/gas/config/obj-coff.c
+++ b/gas/config/obj-coff.c
@@ -2789,7 +2789,7 @@ write_object_file ()
   if (abfd == 0)
     {
       as_perror ("FATAL: Can't create %s", out_file_name);
-      exit (42);
+      exit (EXIT_FAILURE);
     }
   bfd_set_format (abfd, bfd_object);
   bfd_set_arch_mach (abfd, BFD_ARCH, machine);
diff --git a/gas/config/obj-ieee.c b/gas/config/obj-ieee.c
index a99ced2..4cd1794 100644
--- a/gas/config/obj-ieee.c
+++ b/gas/config/obj-ieee.c
@@ -509,7 +509,7 @@ DEFUN_VOID (write_object_file)
   if (abfd == 0)
     {
       as_perror ("FATAL: Can't create %s", out_file_name);
-      exit (42);
+      exit (EXIT_FAILURE);
     }
   bfd_set_format (abfd, bfd_object);
   bfd_set_arch_mach (abfd, bfd_arch_h8300, 0);
diff --git a/gas/config/tc-hppa.c b/gas/config/tc-hppa.c
index 988edd9..ceecc47 100644
--- a/gas/config/tc-hppa.c
+++ b/gas/config/tc-hppa.c
@@ -1396,8 +1396,7 @@ pa_ip (str)
       break;
 
     default:
-      as_bad ("Unknown opcode: `%s'", str);
-      exit (1);
+      as_fatal ("Unknown opcode: `%s'", str);
     }
 
   save_s = str;
@@ -4283,10 +4282,10 @@ pa_comm (unused)
 	  S_SET_SEGMENT (symbol, &bfd_und_section);
 	  S_SET_EXTERNAL (symbol);
 
-	  /* Keep this until we verify that the generic resolving
-	     code in write.c is fixed.  */
-	  symbol->sy_resolved = 1;
-	  
+	  /* colon() has already set the frag to the current location in the
+	     $BSS$ subspace; we need to reset the fragment to the zero address
+	     fragment.  */
+	  symbol->sy_frag = &zero_address_frag;
 	}
     }
   demand_empty_rest_of_line ();
diff --git a/gas/config/tc-mips.c b/gas/config/tc-mips.c
index 510e114..4033c4d 100644
--- a/gas/config/tc-mips.c
+++ b/gas/config/tc-mips.c
@@ -4132,8 +4132,7 @@ mips_ip (str, ip)
       break;
 
     default:
-      as_warn ("Unknown opcode: `%s'", str);
-      exit (1);
+      as_fatal ("Unknown opcode: `%s'", str);
     }
   if ((insn = (struct mips_opcode *) hash_find (op_hash, str)) == NULL)
     {
diff --git a/gas/config/tc-vax.c b/gas/config/tc-vax.c
index abfc568..36a0afe 100644
--- a/gas/config/tc-vax.c
+++ b/gas/config/tc-vax.c
@@ -594,7 +594,7 @@ md_assemble (instruction_string)
 	      expP->X_add_number = floatP->low[0]
 		| ((LITTLENUM_MASK & (floatP->low[1])) << LITTLENUM_NUMBER_OF_BITS);
 	      /*
-	       * For the SEG_BIG case we have:
+	       * For the O_big case we have:
 	       * If vop_short == 's' then a short floating literal is in the
 	       *	lowest 6 bits of floatP -> low [0], which is
 	       *	big_operand_bits [---] [0].
@@ -653,12 +653,6 @@ md_assemble (instruction_string)
       this_add_symbol = expP->X_add_symbol;
       to_seg = *segP;
       is_undefined = (to_seg == SEG_UNKNOWN);
-      know (to_seg == SEG_UNKNOWN
-	    || to_seg == SEG_ABSOLUTE
-	    || to_seg == SEG_DATA
-	    || to_seg == SEG_TEXT
-	    || to_seg == SEG_BSS
-	    || to_seg == SEG_BIG);
       at = operandP->vop_mode & 1;
       length = (operandP->vop_short == 'b'
 		? 1 : (operandP->vop_short == 'w'
@@ -1935,7 +1929,7 @@ main ()
 	}
     }
   vip_end ();
-  exit ();
+  exit (EXIT_SUCCESS);
 }
 
 #endif /* #ifdef test */
@@ -2982,7 +2976,7 @@ main ()
       fflush (stdout);
       gets (answer);
       if (!answer[0])
-	exit (0);
+	exit (EXIT_SUCCESS);
       myaccess = answer[0];
       mywidth = answer[1];
       switch (mywidth)