diff options
author | Tamar Christina <tamar.christina@arm.com> | 2017-12-19 12:05:20 +0000 |
---|---|---|
committer | Tamar Christina <tamar.christina@arm.com> | 2017-12-19 12:21:12 +0000 |
commit | 00c2093f698e8f40c04340cb1832d09e11ece237 (patch) | |
tree | ff7998cdf1ba5a074df429a9c830769477958a85 /gas/config | |
parent | a3b3345ae62503982698171bcfce0afe23bd8a31 (diff) | |
download | gdb-00c2093f698e8f40c04340cb1832d09e11ece237.zip gdb-00c2093f698e8f40c04340cb1832d09e11ece237.tar.gz gdb-00c2093f698e8f40c04340cb1832d09e11ece237.tar.bz2 |
Correct disassembly of dot product instructions.
Dot products deviate from the normal disassembly rules for lane indexed
instruction. Their canonical representation is in the form of:
v0.2s, v0.8b, v0.4b[0] instead of v0.2s, v0.8b, v0.b[0] to try to denote
that these instructions select 4x 1 byte elements instead of a single 1 byte
element.
Previously we were disassembling them following the normal rules, this patch
corrects the disassembly.
gas/
PR gas/22559
* config/tc-aarch64.c (vectype_to_qualifier): Support AARCH64_OPND_QLF_S_4B.
* gas/testsuite/gas/aarch64/dotproduct.d: Update disassembly.
include/
PR gas/22559
* aarch64.h (aarch64_opnd_qualifier): Add AARCH64_OPND_QLF_S_4B.
opcodes/
PR gas/22559
* aarch64-asm.c (aarch64_ins_reglane): Change AARCH64_OPND_QLF_S_B to
AARCH64_OPND_QLF_S_4B
* aarch64-dis.c (aarch64_ext_reglane): Change AARCH64_OPND_QLF_S_B to
AARCH64_OPND_QLF_S_4B
* aarch64-opc.c (aarch64_opnd_qualifiers): Add 4b variant.
* aarch64-tbl.h (QL_V2DOT): Change S_B to S_4B.
Diffstat (limited to 'gas/config')
-rw-r--r-- | gas/config/tc-aarch64.c | 10 |
1 files changed, 8 insertions, 2 deletions
diff --git a/gas/config/tc-aarch64.c b/gas/config/tc-aarch64.c index 6b5179e..9e2cd50 100644 --- a/gas/config/tc-aarch64.c +++ b/gas/config/tc-aarch64.c @@ -4929,8 +4929,14 @@ vectype_to_qualifier (const struct vector_type_el *vectype) gas_assert (vectype->type >= NT_b && vectype->type <= NT_q); if (vectype->defined & (NTA_HASINDEX | NTA_HASVARWIDTH)) - /* Vector element register. */ - return AARCH64_OPND_QLF_S_B + vectype->type; + { + /* Special case S_4B. */ + if (vectype->type == NT_b && vectype->width == 4) + return AARCH64_OPND_QLF_S_4B; + + /* Vector element register. */ + return AARCH64_OPND_QLF_S_B + vectype->type; + } else { /* Vector register. */ |