diff options
| author | Alex Coplan <alex.coplan@arm.com> | 2021-05-17 15:12:39 +0100 |
|---|---|---|
| committer | Alex Coplan <alex.coplan@arm.com> | 2021-05-17 15:12:39 +0100 |
| commit | e683cb412046b40085505f42dd141f542661a6ae (patch) | |
| tree | 5691bbcb60d26278a40eb4265c53db1e0a33af35 /gas/config/tc-arm.c | |
| parent | 467f8eb233291031e1883c12fae9c8f41177efa2 (diff) | |
| download | gdb-e683cb412046b40085505f42dd141f542661a6ae.zip gdb-e683cb412046b40085505f42dd141f542661a6ae.tar.gz gdb-e683cb412046b40085505f42dd141f542661a6ae.tar.bz2 | |
arm: Fix bugs with MVE vmov from two GPRs to vector lanes
The initial problem I wanted to fix here is that GAS was rejecting MVE
instructions such as:
vmov q3[2], q3[0], r2, r2
with:
Error: General purpose registers may not be the same -- `vmov q3[2],q3[0],r2,r2'
which is incorrect; such instructions are valid. Note that for moves in
the other direction, e.g.:
vmov r2, r2, q3[2], q3[0]
GAS is correct in rejecting this as it does not make sense to move both
lanes into the same register (the Arm ARM says this is CONSTRAINED
UNPREDICTABLE).
After fixing this issue, I added assembly/disassembly tests for these
vmovs. This revealed several disassembly issues, including incorrectly
marking the moves into vector lanes as UNPREDICTABLE, and disassembling
many of the vmovs as vector loads. These are now fixed.
gas/ChangeLog:
* config/tc-arm.c (do_mve_mov): Only reject vmov if we're moving
into the same GPR twice.
* testsuite/gas/arm/mve-vmov-bad-2.l: Tweak error message.
* testsuite/gas/arm/mve-vmov-3.d: New test.
* testsuite/gas/arm/mve-vmov-3.s: New test.
opcodes/ChangeLog:
* arm-dis.c (mve_opcodes): Fix disassembly of
MVE_VMOV2_GP_TO_VEC_LANE when idx == 1.
(is_mve_encoding_conflict): MVE vector loads should not match
when P = W = 0.
(is_mve_unpredictable): It's not unpredictable to use the same
source register twice (for MVE_VMOV2_GP_TO_VEC_LANE).
Diffstat (limited to 'gas/config/tc-arm.c')
| -rw-r--r-- | gas/config/tc-arm.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/gas/config/tc-arm.c b/gas/config/tc-arm.c index 4888c08..9229dd0 100644 --- a/gas/config/tc-arm.c +++ b/gas/config/tc-arm.c @@ -20013,8 +20013,8 @@ do_mve_mov (int toQ) constraint (inst.operands[Q0].reg != inst.operands[Q1].reg + 2, _("Index one must be [2,3] and index two must be two less than" " index one.")); - constraint (inst.operands[Rt].reg == inst.operands[Rt2].reg, - _("General purpose registers may not be the same")); + constraint (!toQ && inst.operands[Rt].reg == inst.operands[Rt2].reg, + _("Destination registers may not be the same")); constraint (inst.operands[Rt].reg == REG_SP || inst.operands[Rt2].reg == REG_SP, BAD_SP); |