diff options
| author | Richard Sandiford <richard.sandiford@arm.com> | 2016-09-21 17:11:04 +0100 |
|---|---|---|
| committer | Richard Sandiford <richard.sandiford@arm.com> | 2016-09-21 17:11:04 +0100 |
| commit | ab3b8fcfdb06695d27eaec4eedb019ada4a5713e (patch) | |
| tree | 4812f6a2733a32bbeed7a79df63645d47bdcbdf9 /gas/config/tc-aarch64.c | |
| parent | bb7eff5206e4795ac79c177a80fe9f4630aaf730 (diff) | |
| download | gdb-ab3b8fcfdb06695d27eaec4eedb019ada4a5713e.zip gdb-ab3b8fcfdb06695d27eaec4eedb019ada4a5713e.tar.gz gdb-ab3b8fcfdb06695d27eaec4eedb019ada4a5713e.tar.bz2 | |
[AArch64] Use "must" rather than "should" in error messages
One of the review comments from the SVE series was that it would
be better to use "must" rather than "should" in error messages.
I think this patch fixes all cases in the AArch64 code.
It also uses "must be" instead of "expected to be".
opcodes/
* aarch64-opc.c (operand_general_constraint_met_p): Use "must be"
rather than "should be" or "expected to be" in error messages.
gas/
* config/tc-aarch64.c (output_operand_error_record): Use "must be"
rather than "should be" or "expected to be" in error messages.
(parse_operands): Likewise.
* testsuite/gas/aarch64/diagnostic.l: Likewise.
* testsuite/gas/aarch64/legacy_reg_names.l: Likewise.
* testsuite/gas/aarch64/sve-invalid.l: Likewise.
* testsuite/gas/aarch64/sve-reg-diagnostic.l: Likewise.
Diffstat (limited to 'gas/config/tc-aarch64.c')
| -rw-r--r-- | gas/config/tc-aarch64.c | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/gas/config/tc-aarch64.c b/gas/config/tc-aarch64.c index bc39fe9..9963c61 100644 --- a/gas/config/tc-aarch64.c +++ b/gas/config/tc-aarch64.c @@ -4543,7 +4543,7 @@ output_operand_error_record (const operand_error_record *record, char *str) else { gas_assert (idx >= 0); - as_bad (_("operand %d should be %s -- `%s'"), idx + 1, + as_bad (_("operand %d must be %s -- `%s'"), idx + 1, aarch64_get_operand_desc (opd_code), str); } break; @@ -4656,7 +4656,7 @@ output_operand_error_record (const operand_error_record *record, char *str) detail->error ? detail->error : _("immediate value"), detail->data[0], detail->data[1], idx + 1, str); else - as_bad (_("%s expected to be %d at operand %d -- `%s'"), + as_bad (_("%s must be %d at operand %d -- `%s'"), detail->error ? detail->error : _("immediate value"), detail->data[0], idx + 1, str); break; @@ -4673,7 +4673,7 @@ output_operand_error_record (const operand_error_record *record, char *str) break; case AARCH64_OPDE_UNALIGNED: - as_bad (_("immediate value should be a multiple of " + as_bad (_("immediate value must be a multiple of " "%d at operand %d -- `%s'"), detail->data[0], idx + 1, str); break; @@ -6056,7 +6056,7 @@ parse_operands (char *str, const aarch64_opcode *opcode) else { set_fatal_syntax_error - (_("writeback value should be an immediate constant")); + (_("writeback value must be an immediate constant")); goto failure; } } |