diff options
| author | Clément Chigot <chigot@adacore.com> | 2023-10-17 14:57:25 +0200 |
|---|---|---|
| committer | Clément Chigot <chigot@adacore.com> | 2023-10-23 10:17:47 +0200 |
| commit | be381d7175e4cb8de506d9175969396669fe5b88 (patch) | |
| tree | 5a17fc7b8f19fc6761f10663b254720819bfcbf2 /binutils | |
| parent | 4d47dfdba34de3bbd6c7433d024a5d049e29bed4 (diff) | |
| download | gdb-be381d7175e4cb8de506d9175969396669fe5b88.zip gdb-be381d7175e4cb8de506d9175969396669fe5b88.tar.gz gdb-be381d7175e4cb8de506d9175969396669fe5b88.tar.bz2 | |
objcopy: fix typo in --heap and --stack parser
The help says that <reserve> and <commit> should be separated by a ","
but the implementation is checking for ".". Having two numbers being
separated by a "." could be confusing, thus adjust the implementation to
match the help syntax.
binutils/ChangeLog:
* objcopy.c (copy_main): Set separator to "," between <reserve>
and <commit> for --heap and --stack.
* doc/binutils.texi: Add <commit> for --heap and --stack.
Diffstat (limited to 'binutils')
| -rw-r--r-- | binutils/doc/binutils.texi | 4 | ||||
| -rw-r--r-- | binutils/objcopy.c | 4 |
2 files changed, 4 insertions, 4 deletions
diff --git a/binutils/doc/binutils.texi b/binutils/doc/binutils.texi index 0d46119..f946936 100644 --- a/binutils/doc/binutils.texi +++ b/binutils/doc/binutils.texi @@ -1330,10 +1330,10 @@ objcopy [@option{-F} @var{bfdname}|@option{--target=}@var{bfdname}] [@option{--pure}] [@option{--impure}] [@option{--file-alignment=}@var{num}] - [@option{--heap=}@var{size}] + [@option{--heap=}@var{reserve}[,@var{commit}]] [@option{--image-base=}@var{address}] [@option{--section-alignment=}@var{num}] - [@option{--stack=}@var{size}] + [@option{--stack=}@var{reserve}[,@var{commit}]] [@option{--subsystem=}@var{which}:@var{major}.@var{minor}] [@option{--compress-debug-sections}] [@option{--decompress-debug-sections}] diff --git a/binutils/objcopy.c b/binutils/objcopy.c index ba304c2..6bc84bd 100644 --- a/binutils/objcopy.c +++ b/binutils/objcopy.c @@ -5910,7 +5910,7 @@ copy_main (int argc, char *argv[]) char *end; pe_heap_reserve = strtoul (optarg, &end, 0); if (end == optarg - || (*end != '.' && *end != '\0')) + || (*end != ',' && *end != '\0')) non_fatal (_("%s: invalid reserve value for --heap"), optarg); else if (*end != '\0') @@ -5941,7 +5941,7 @@ copy_main (int argc, char *argv[]) char *end; pe_stack_reserve = strtoul (optarg, &end, 0); if (end == optarg - || (*end != '.' && *end != '\0')) + || (*end != ',' && *end != '\0')) non_fatal (_("%s: invalid reserve value for --stack"), optarg); else if (*end != '\0') |