aboutsummaryrefslogtreecommitdiff
path: root/binutils
diff options
context:
space:
mode:
authorAlan Modra <amodra@gmail.com>2018-09-11 23:50:15 +0930
committerAlan Modra <amodra@gmail.com>2018-09-14 21:21:28 +0930
commita4cd947aca23d58966ead843e120f4c19db01030 (patch)
treece6ff23107b69400deda148ed6eac20e4f7312c9 /binutils
parent556059dd13a8a9a30b23eacbefbe7b85e74ce7b7 (diff)
downloadgdb-a4cd947aca23d58966ead843e120f4c19db01030.zip
gdb-a4cd947aca23d58966ead843e120f4c19db01030.tar.gz
gdb-a4cd947aca23d58966ead843e120f4c19db01030.tar.bz2
PR23425, unresolved symbol diagnostic
dwarf2.c code reasonably assumes that debug info is local to a file, an assumption now violated by gcc, resulting in "DWARF error: invalid abstract instance DIE ref" or wrong details when attempting to print linker error messages with file, function and line reported. This is because find_abstract_instance is only prepared to handle DW_FORM_ref_addr when the .debug_info section referenced is in the current file. When that isn't the case, relocations to access another file's .debug_info will typically be against a symbol defined at the start of that .debug_info section, plus an addend. Since the dwarf2.c code only considers the current file's debug info, that symbol will be undefined, resolving to zero. In effect the ref_addr will wrongly resolve to the current file's .debug_info. This patch avoids the problem by treating relocations in debug sections against undefined symbols in a similar manner to the way relocations against symbols defined in discarded sections are resolved. They result in a zero value (except in .debug_ranges) regardless of the addend. PR 23425 * reloc.c (bfd_generic_get_relocated_section_contents): Zero reloc fields in debug sections when reloc is against an undefined symbol and called from bfd_simple_get_relocated_section_contents or similar. * dwarf2.c (find_abstract_instance): Return true for zero offset DW_FORM_ref_addr without returning values.
Diffstat (limited to 'binutils')
0 files changed, 0 insertions, 0 deletions