diff options
| author | Alan Modra <amodra@gmail.com> | 2011-05-06 14:41:56 +0000 |
|---|---|---|
| committer | Alan Modra <amodra@gmail.com> | 2011-05-06 14:41:56 +0000 |
| commit | 19094d10cd61cb12b8725a4a1495f16c3f842df0 (patch) | |
| tree | 29d003aaafb70ea21ee30d2a20334f999d64d2f2 /binutils | |
| parent | d8228535f5e83861361a366e2298a4d8c79e78d8 (diff) | |
| download | gdb-19094d10cd61cb12b8725a4a1495f16c3f842df0.zip gdb-19094d10cd61cb12b8725a4a1495f16c3f842df0.tar.gz gdb-19094d10cd61cb12b8725a4a1495f16c3f842df0.tar.bz2 | |
* objcopy.c (copy_archive): Check bfd_openw result in unknown object
case. Rewrite without goto.
Diffstat (limited to 'binutils')
| -rw-r--r-- | binutils/ChangeLog | 5 | ||||
| -rw-r--r-- | binutils/objcopy.c | 61 |
2 files changed, 35 insertions, 31 deletions
diff --git a/binutils/ChangeLog b/binutils/ChangeLog index 4e709b6..32b623d 100644 --- a/binutils/ChangeLog +++ b/binutils/ChangeLog @@ -1,3 +1,8 @@ +2011-05-07 Alan Modra <amodra@gmail.com> + + * objcopy.c (copy_archive): Check bfd_openw result in unknown object + case. Rewrite without goto. + 2011-05-03 Jakub Jelinek <jakub@redhat.com> * dwarf.c (decode_location_expression): Handle DW_OP_GNU_const_type, diff --git a/binutils/objcopy.c b/binutils/objcopy.c index 15c4f95..b64f3d0 100644 --- a/binutils/objcopy.c +++ b/binutils/objcopy.c @@ -1,6 +1,6 @@ /* objcopy.c -- copy object file from input to output, optionally massaging it. Copyright 1991, 1992, 1993, 1994, 1995, 1996, 1997, 1998, 1999, 2000, - 2001, 2002, 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2010 + 2001, 2002, 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Free Software Foundation, Inc. This file is part of GNU Binutils. @@ -2024,6 +2024,7 @@ copy_archive (bfd *ibfd, bfd *obfd, const char *output_target, struct stat buf; int stat_status = 0; bfd_boolean del = TRUE; + bfd_boolean ok_object; /* Create an output file for this member. */ output_name = concat (dir, "/", @@ -2061,44 +2062,42 @@ copy_archive (bfd *ibfd, bfd *obfd, const char *output_target, l->obfd = NULL; list = l; - if (bfd_check_format (this_element, bfd_object)) + ok_object = bfd_check_format (this_element, bfd_object); + if (!ok_object) + bfd_nonfatal_message (NULL, this_element, NULL, + _("Unable to recognise the format of file")); + + /* PR binutils/3110: Cope with archives + containing multiple target types. */ + if (force_output_target || !ok_object) + output_bfd = bfd_openw (output_name, output_target); + else + output_bfd = bfd_openw (output_name, bfd_get_target (this_element)); + + if (output_bfd == NULL) { - /* PR binutils/3110: Cope with archives - containing multiple target types. */ - if (force_output_target) - output_bfd = bfd_openw (output_name, output_target); - else - output_bfd = bfd_openw (output_name, bfd_get_target (this_element)); + bfd_nonfatal_message (output_name, NULL, NULL, NULL); + status = 1; + return; + } + + if (ok_object) + { + del = !copy_object (this_element, output_bfd, input_arch); - if (output_bfd == NULL) + if (del && bfd_get_arch (this_element) == bfd_arch_unknown) + /* Try again as an unknown object file. */ + ok_object = FALSE; + else if (!bfd_close (output_bfd)) { bfd_nonfatal_message (output_name, NULL, NULL, NULL); + /* Error in new object file. Don't change archive. */ status = 1; - return; } - - del = ! copy_object (this_element, output_bfd, input_arch); - - if (! del - || bfd_get_arch (this_element) != bfd_arch_unknown) - { - if (!bfd_close (output_bfd)) - { - bfd_nonfatal_message (output_name, NULL, NULL, NULL); - /* Error in new object file. Don't change archive. */ - status = 1; - } - } - else - goto copy_unknown_element; } - else - { - bfd_nonfatal_message (NULL, this_element, NULL, - _("Unable to recognise the format of file")); - output_bfd = bfd_openw (output_name, output_target); -copy_unknown_element: + if (!ok_object) + { del = !copy_unknown_object (this_element, output_bfd); if (!bfd_close_all_done (output_bfd)) { |