diff options
| author | Nick Clifton <nickc@redhat.com> | 2022-09-01 14:51:50 +0100 |
|---|---|---|
| committer | Nick Clifton <nickc@redhat.com> | 2022-09-01 14:51:50 +0100 |
| commit | f4492fb683013d7de6f4788df6deb24fed8671b4 (patch) | |
| tree | 968cfab21701dc4cc1c83e070dd4382261888cca /binutils | |
| parent | 7b0d7ede79f548915641ac5916fbeb77fc9c44ff (diff) | |
| download | gdb-f4492fb683013d7de6f4788df6deb24fed8671b4.zip gdb-f4492fb683013d7de6f4788df6deb24fed8671b4.tar.gz gdb-f4492fb683013d7de6f4788df6deb24fed8671b4.tar.bz2 | |
dllwrap, windres and dlltools use mktemp, which should be avoided
PR 29534
* dllwrap.c: Replace uses of choose_temp_base() with
make_temp_file().
* dlltool.c: Likewise.
* resrc.c: Likewise.
Diffstat (limited to 'binutils')
| -rw-r--r-- | binutils/ChangeLog | 8 | ||||
| -rw-r--r-- | binutils/dlltool.c | 2 | ||||
| -rw-r--r-- | binutils/dllwrap.c | 6 | ||||
| -rw-r--r-- | binutils/resrc.c | 4 |
4 files changed, 14 insertions, 6 deletions
diff --git a/binutils/ChangeLog b/binutils/ChangeLog index 04ef77c..b571109 100644 --- a/binutils/ChangeLog +++ b/binutils/ChangeLog @@ -1,3 +1,11 @@ +2022-09-01 Nick Clifton <nickc@redhat.com> + + PR 29534 + * dllwrap.c: Replace uses of choose_temp_base() with + make_temp_file(). + * dlltool.c: Likewise. + * resrc.c: Likewise. + 2022-08-23 Nick Clifton <nickc@redhat.com> PR 29489 diff --git a/binutils/dlltool.c b/binutils/dlltool.c index b4ac842..a3c5e0f 100644 --- a/binutils/dlltool.c +++ b/binutils/dlltool.c @@ -1270,7 +1270,7 @@ run (const char *what, char *args) int i; const char **argv; char *errmsg_fmt = NULL, *errmsg_arg = NULL; - char *temp_base = choose_temp_base (); + char *temp_base = make_temp_file (""); inform (_("run: %s %s"), what, args); diff --git a/binutils/dllwrap.c b/binutils/dllwrap.c index 1be3cec..7c77701 100644 --- a/binutils/dllwrap.c +++ b/binutils/dllwrap.c @@ -351,7 +351,7 @@ run (const char *what, char *args) int i; const char **argv; char *errmsg_fmt = NULL, *errmsg_arg = NULL; - char *temp_base = choose_temp_base (); + char *temp_base = make_temp_file (NULL); int in_quote; char sep; @@ -818,7 +818,7 @@ main (int argc, char **argv) if (! def_file_seen) { - char *fileprefix = choose_temp_base (); + char *fileprefix = make_temp_file (NULL); def_file_name = (char *) xmalloc (strlen (fileprefix) + 5); sprintf (def_file_name, "%s.def", @@ -1031,7 +1031,7 @@ Creating one, but that may not be what you want")); if (! base_file_name) { - char *fileprefix = choose_temp_base (); + char *fileprefix = make_temp_file (NULL); base_file_name = (char *) xmalloc (strlen (fileprefix) + 6); sprintf (base_file_name, "%s.base", (dontdeltemps) ? mybasename (fileprefix) : fileprefix); diff --git a/binutils/resrc.c b/binutils/resrc.c index fff77f4..2cf168e 100644 --- a/binutils/resrc.c +++ b/binutils/resrc.c @@ -202,7 +202,7 @@ run_cmd (char *cmd, const char *redir) int i; const char **argv; char *errmsg_fmt = NULL, *errmsg_arg = NULL; - char *temp_base = choose_temp_base (); + char *temp_base = make_temp_file (NULL); int in_quote; char sep; int redir_handle = -1; @@ -316,7 +316,7 @@ open_input_stream (char *cmd) { char *fileprefix; - fileprefix = choose_temp_base (); + fileprefix = make_temp_file (NULL); cpp_temp_file = (char *) xmalloc (strlen (fileprefix) + 5); sprintf (cpp_temp_file, "%s.irc", fileprefix); free (fileprefix); |