diff options
| author | Nick Clifton <nickc@redhat.com> | 2020-03-02 10:02:02 +0000 |
|---|---|---|
| committer | Nick Clifton <nickc@redhat.com> | 2020-03-02 10:02:02 +0000 |
| commit | ba3265d04cc794d2af8b7d590a0658f7d732071c (patch) | |
| tree | 130a816b897725b0eae9cfdc8ed5a711a48feed5 /binutils/testsuite | |
| parent | cb001c0d283dd884efe06770d033a50fb1bc6c7d (diff) | |
| download | gdb-ba3265d04cc794d2af8b7d590a0658f7d732071c.zip gdb-ba3265d04cc794d2af8b7d590a0658f7d732071c.tar.gz gdb-ba3265d04cc794d2af8b7d590a0658f7d732071c.tar.bz2 | |
Restore readelf's string dump to previous behaviour where newlines were caused line breaks.
PR 25543
* readelf.c (dump_section_as_strings): Display new-line characters
as \n and then insert a line break.
* testsuite/binutils-all/pr25543.s: New test.
* testsuite/binutils-all/pr25543.d: Test driver.
* testsuite/binutils-all/readelf.exp: Run the new test.
Diffstat (limited to 'binutils/testsuite')
| -rw-r--r-- | binutils/testsuite/binutils-all/pr25543.d | 12 | ||||
| -rw-r--r-- | binutils/testsuite/binutils-all/pr25543.s | 7 | ||||
| -rw-r--r-- | binutils/testsuite/binutils-all/readelf.exp | 1 |
3 files changed, 20 insertions, 0 deletions
diff --git a/binutils/testsuite/binutils-all/pr25543.d b/binutils/testsuite/binutils-all/pr25543.d new file mode 100644 index 0000000..75f2392 --- /dev/null +++ b/binutils/testsuite/binutils-all/pr25543.d @@ -0,0 +1,12 @@ +#source: pr25543.s +#readelf: -p.data +#notarget: rx-* + +String dump of section '.data': + \[ 0\] line1 : This is a line without a newline at the end + \[ 34\] line2 : This is a line with a newline at the end\\n + \[ 66\] line3 : This is a line with a \\n + newline in the middle + \[ 9b\] line4 : This is a line with a \^Mcontrol character + \[ cd\] line6 : The previous line was empty\\n +#pass diff --git a/binutils/testsuite/binutils-all/pr25543.s b/binutils/testsuite/binutils-all/pr25543.s new file mode 100644 index 0000000..71bfe05 --- /dev/null +++ b/binutils/testsuite/binutils-all/pr25543.s @@ -0,0 +1,7 @@ + .data + .asciz "line1 : This is a line without a newline at the end" + .asciz "line2 : This is a line with a newline at the end\n" + .asciz "line3 : This is a line with a \nnewline in the middle" + .asciz "line4 : This is a line with a \rcontrol character" + .asciz "" + .asciz "line6 : The previous line was empty\n" diff --git a/binutils/testsuite/binutils-all/readelf.exp b/binutils/testsuite/binutils-all/readelf.exp index 2f9afed..cc78e66 100644 --- a/binutils/testsuite/binutils-all/readelf.exp +++ b/binutils/testsuite/binutils-all/readelf.exp @@ -349,6 +349,7 @@ readelf_wi_test readelf_compressed_wa_test readelf_dump_test +run_dump_test "pr25543" # PR 13482 - Check for off-by-one errors when dumping .note sections. if {![binutils_assemble $srcdir/$subdir/version.s tmpdir/version.o]} then { |