diff options
author | H.J. Lu <hjl.tools@gmail.com> | 2015-09-29 09:35:47 -0700 |
---|---|---|
committer | H.J. Lu <hjl.tools@gmail.com> | 2015-09-29 13:31:57 -0700 |
commit | cbd44e247ede49688e1e1fa42e57d390ad141967 (patch) | |
tree | 7296da5e95dea5f24228fc3499a8ffc84c861b3e /binutils/testsuite | |
parent | 0bcf3dd6905d67936815411b42dab6fd4c47b4db (diff) | |
download | gdb-cbd44e247ede49688e1e1fa42e57d390ad141967.zip gdb-cbd44e247ede49688e1e1fa42e57d390ad141967.tar.gz gdb-cbd44e247ede49688e1e1fa42e57d390ad141967.tar.bz2 |
Don't use the output section size to copy input section
We can't use the output section size to copy input section since
--interleave will shrink the output section. Instead, we change
bfd_convert_section_contents to return the updated input section
size. When we do that, we don't need to adjust the output section
size to skip gap fills.
bfd/
PR binutils/19020
* bfd.c (bfd_convert_section_contents): Add ptr_size parameter.
* bfd-in2.h: Regenerated.
binutils/
PR binutils/19020
* objcopy.c (copy_object): Don't adjust the output section size
when copying from input sections.
(copy_section): Use input section size for the copy. Get the
updated section size from bfd_convert_section_contents.
binutils/testsuite/
PR binutils/19020
* binutils-all/objcopy.exp: Run pr19020a and pr19020b.
* lib/utils-lib.exp (run_dump_test): Support binary input.
* binutils-all/pr19020.in: New file.
* binutils-all/pr19020a.d: Likewise.
* binutils-all/pr19020b.d: Likewise.
Diffstat (limited to 'binutils/testsuite')
-rw-r--r-- | binutils/testsuite/ChangeLog | 9 | ||||
-rw-r--r-- | binutils/testsuite/binutils-all/objcopy.exp | 2 | ||||
-rw-r--r-- | binutils/testsuite/binutils-all/pr19020.in | 1 | ||||
-rw-r--r-- | binutils/testsuite/binutils-all/pr19020a.d | 9 | ||||
-rw-r--r-- | binutils/testsuite/binutils-all/pr19020b.d | 9 | ||||
-rw-r--r-- | binutils/testsuite/lib/utils-lib.exp | 16 |
6 files changed, 40 insertions, 6 deletions
diff --git a/binutils/testsuite/ChangeLog b/binutils/testsuite/ChangeLog index 9efe4dc..f444dc7 100644 --- a/binutils/testsuite/ChangeLog +++ b/binutils/testsuite/ChangeLog @@ -1,3 +1,12 @@ +2015-09-29 H.J. Lu <hongjiu.lu@intel.com> + + PR binutils/19020 + * binutils-all/objcopy.exp: Run pr19020a and pr19020b. + * lib/utils-lib.exp (run_dump_test): Support binary input. + * binutils-all/pr19020.in: New file. + * binutils-all/pr19020a.d: Likewise. + * binutils-all/pr19020b.d: Likewise. + 2015-08-11 Alan Modra <amodra@gmail.com> * binutils-all/strip-12.s: Align .bss section. diff --git a/binutils/testsuite/binutils-all/objcopy.exp b/binutils/testsuite/binutils-all/objcopy.exp index cb8e33b..bb33e4f 100644 --- a/binutils/testsuite/binutils-all/objcopy.exp +++ b/binutils/testsuite/binutils-all/objcopy.exp @@ -1022,6 +1022,8 @@ if [is_elf_format] { run_dump_test "copy-2" run_dump_test "copy-3" run_dump_test "copy-4" +run_dump_test "pr19020a" +run_dump_test "pr19020b" if [is_elf_format] { run_dump_test "strip-1" diff --git a/binutils/testsuite/binutils-all/pr19020.in b/binutils/testsuite/binutils-all/pr19020.in new file mode 100644 index 0000000..1656f92 --- /dev/null +++ b/binutils/testsuite/binutils-all/pr19020.in @@ -0,0 +1 @@ +abcdefgh
\ No newline at end of file diff --git a/binutils/testsuite/binutils-all/pr19020a.d b/binutils/testsuite/binutils-all/pr19020a.d new file mode 100644 index 0000000..71d5813 --- /dev/null +++ b/binutils/testsuite/binutils-all/pr19020a.d @@ -0,0 +1,9 @@ +#PROG: objcopy +#source: pr19020.in +#as: binary +#objcopy: -O binary -I binary --pad-to=10 --gap-fill=65 --interleave=2 --interleave-width=1 --byte=0 +#objdump: -b binary -s + +#... +Contents of section .data: + 0000 61636567 41414141 4141 +acegAAAAAA + diff --git a/binutils/testsuite/binutils-all/pr19020b.d b/binutils/testsuite/binutils-all/pr19020b.d new file mode 100644 index 0000000..41dc650 --- /dev/null +++ b/binutils/testsuite/binutils-all/pr19020b.d @@ -0,0 +1,9 @@ +#PROG: objcopy +#source: pr19020.in +#as: binary +#objcopy: -O binary -I binary --pad-to=10 --gap-fill=65 --reverse-bytes=8 +#objdump: -b binary -s + +#... +Contents of section .data: + 0000 68676665 64636261 4141 +hgfedcbaAA + diff --git a/binutils/testsuite/lib/utils-lib.exp b/binutils/testsuite/lib/utils-lib.exp index 9c24cf1..fd5b6f6 100644 --- a/binutils/testsuite/lib/utils-lib.exp +++ b/binutils/testsuite/lib/utils-lib.exp @@ -447,12 +447,16 @@ proc run_dump_test { name {extra_options {}} } { set srcfile $srcdir/$subdir/$opts(source) } - set exec_output [binutils_assemble_flags ${srcfile} $tempfile $opts(as)] - if [string match "" $exec_output] then { - send_log "$exec_output\n" - verbose "$exec_output" - fail $testname - return + if { $opts(as) == "binary" } { + file copy -force ${srcfile} $tempfile + } else { + set exec_output [binutils_assemble_flags ${srcfile} $tempfile $opts(as)] + if [string match "" $exec_output] then { + send_log "$exec_output\n" + verbose "$exec_output" + fail $testname + return + } } set progopts1 $opts($program) |