aboutsummaryrefslogtreecommitdiff
path: root/binutils/stabs.c
diff options
context:
space:
mode:
authorNick Clifton <nickc@redhat.com>2017-02-14 14:07:29 +0000
committerNick Clifton <nickc@redhat.com>2017-02-14 14:07:29 +0000
commita2dea0b20bc66a4c287c3c50002b8c3b3e9d953a (patch)
tree15d50ee1ef472a206bec48b99f3527a28c9598e2 /binutils/stabs.c
parentb32e566ba6ee02687c6def22ade0899076adf7dd (diff)
downloadgdb-a2dea0b20bc66a4c287c3c50002b8c3b3e9d953a.zip
gdb-a2dea0b20bc66a4c287c3c50002b8c3b3e9d953a.tar.gz
gdb-a2dea0b20bc66a4c287c3c50002b8c3b3e9d953a.tar.bz2
Fix handling of corrupt STABS enum type strings.
PR binutils/21157 * stabs.c (parse_stab_enum_type): Check for corrupt NAME:VALUE pairs. (parse_number): Exit early if passed an empty string.
Diffstat (limited to 'binutils/stabs.c')
-rw-r--r--binutils/stabs.c14
1 files changed, 13 insertions, 1 deletions
diff --git a/binutils/stabs.c b/binutils/stabs.c
index d3fc4af..3861f83 100644
--- a/binutils/stabs.c
+++ b/binutils/stabs.c
@@ -232,6 +232,10 @@ parse_number (const char **pp, bfd_boolean *poverflow)
orig = *pp;
+ /* Stop early if we are passed an empty string. */
+ if (*orig == 0)
+ return (bfd_vma) 0;
+
errno = 0;
ul = strtoul (*pp, (char **) pp, 0);
if (ul + 1 != 0 || errno == 0)
@@ -1975,9 +1979,17 @@ parse_stab_enum_type (void *dhandle, const char **pp)
bfd_signed_vma val;
p = *pp;
- while (*p != ':')
+ while (*p != ':' && *p != 0)
++p;
+ if (*p == 0)
+ {
+ bad_stab (orig);
+ free (names);
+ free (values);
+ return DEBUG_TYPE_NULL;
+ }
+
name = savestring (*pp, p - *pp);
*pp = p + 1;