diff options
author | Joel Brobecker <brobecker@gnat.com> | 2012-11-26 17:41:44 +0000 |
---|---|---|
committer | Joel Brobecker <brobecker@gnat.com> | 2012-11-26 17:41:44 +0000 |
commit | 17d6efc44b4779a1a8a95645daf293a587ef3da9 (patch) | |
tree | e27dfa9d556359109c17f73855dafb8e6889931c /binutils/resres.c | |
parent | 210bbc17ac115d12dbde59b5de97b8547e7465c8 (diff) | |
download | gdb-17d6efc44b4779a1a8a95645daf293a587ef3da9.zip gdb-17d6efc44b4779a1a8a95645daf293a587ef3da9.tar.gz gdb-17d6efc44b4779a1a8a95645daf293a587ef3da9.tar.bz2 |
Do not crash when calling GDB with empty executable name.
% gdb -q ''
... or ...
% gdb -q
(gdb) file ''
... both cause GDB to crash with an invalid free. This is because
exec_file_attach is attempting to free a string that has not been
allocated. The string is only allocated if openp is successful.
But in the case of this obviously invalid filename, openp fails,
and leaves scratch_pathname uninitialized, thus causing the xfree
to fail.
The fix is to enable the associated cleanup after we have verified
that openp was successful.
gdb/ChangeLog (By Keith Seitz <keiths@redhat.com>):
* exec.c (exec_file_attach): Move cleanup after verifying that
memory has in fact been allocated.
gdb/testsuite/ChangeLog:
* gdb.base/empty_exe.exp: New testcase.
Diffstat (limited to 'binutils/resres.c')
0 files changed, 0 insertions, 0 deletions