diff options
| author | Alan Modra <amodra@gmail.com> | 2021-04-14 12:42:27 +0930 |
|---|---|---|
| committer | Alan Modra <amodra@gmail.com> | 2021-04-14 15:06:11 +0930 |
| commit | 13acb58d42e7c66d0d69240cc6b7a0fbf8290da4 (patch) | |
| tree | d604a4a4ff4ed2999618405c5635f106e4b99e26 /binutils/objdump.c | |
| parent | d20eb46617fc6170e144f80dcbaffbc3f4ff6090 (diff) | |
| download | gdb-13acb58d42e7c66d0d69240cc6b7a0fbf8290da4.zip gdb-13acb58d42e7c66d0d69240cc6b7a0fbf8290da4.tar.gz gdb-13acb58d42e7c66d0d69240cc6b7a0fbf8290da4.tar.bz2 | |
PR27716, build failure for msdosdjgpp: PATH_MAX undeclared
We shouldn't be using arbitrary limits like PATH_MAX in GNU programs.
This patch also fixes some memory leaks in readelf when processing
separate debug info.
PR 27716
binutils/
* objdump.c (show_line): Don't limit paths to PATH_MAX.
* readelf.c (struct filedata): Change program_interpreter from
a char array to a char pointer.
(process_program_headers): Sanity check PT_INTERP p_filesz.
Malloc program_interpreter using p_filesz and read directly from
file.
(process_dynamic_section): Check program_interpreter is non-NULL.
(free_filedata): New function, split out from..
(process_object): ..here.
(close_debug_file): Call free_filedata.
* sysdep.h: Don't include sys/param.h.
(PATH_MAX): Don't define.
* configure.ac: Don't check for sys/param.h.
* configure: Regenerate.
gprof/
* gprof.h (PATH_MAX): Don't define.
* corefile.c (core_create_line_syms): Don't use PATH_MAX for initial
file name size.
* source.c (annotate_source): Malloc file name buffer. Always
trim off "-ann" when dos 8.3 annotate file matches original.
* utils.c (print_name_only): Malloc file name buffer.
Diffstat (limited to 'binutils/objdump.c')
| -rw-r--r-- | binutils/objdump.c | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/binutils/objdump.c b/binutils/objdump.c index 3e6bf72..39b5793 100644 --- a/binutils/objdump.c +++ b/binutils/objdump.c @@ -1739,7 +1739,7 @@ show_line (bfd *abfd, asection *section, bfd_vma addr_offset) char *path_up; const char *fname = filename; - path = xmalloc (prefix_length + PATH_MAX + 1); + path = xmalloc (prefix_length + 1 + strlen (filename)); if (prefix_length) memcpy (path, prefix, prefix_length); @@ -1762,8 +1762,7 @@ show_line (bfd *abfd, asection *section, bfd_vma addr_offset) } /* Update complete filename. */ - strncpy (path_up, fname, PATH_MAX); - path_up[PATH_MAX] = '\0'; + strcpy (path_up, fname); filename = path; reloc = true; |