diff options
| author | Alan Modra <amodra@gmail.com> | 2022-06-16 14:48:13 +0930 |
|---|---|---|
| committer | Alan Modra <amodra@gmail.com> | 2022-06-16 15:01:14 +0930 |
| commit | 370426d0da768345fb53683c803d6d5a20558065 (patch) | |
| tree | dc3e9cab9672e0a09b4113ecf0b7365780d07fbc /binutils/objcopy.c | |
| parent | 8ad7c8be4b5705a1138f7b2922ab7611e1d61e06 (diff) | |
| download | gdb-370426d0da768345fb53683c803d6d5a20558065.zip gdb-370426d0da768345fb53683c803d6d5a20558065.tar.gz gdb-370426d0da768345fb53683c803d6d5a20558065.tar.bz2 | |
Always free matching vector from bfd_check_format_matches
At least one place calling list_matching_formats failed to free the
"matching" vector from bfd_check_format_matches afterwards. Fix that
by calling free inside list_matching_formats.
binutils/
* bucomm.c (list_matching_formats): Free arg.
* addr2line.c (process_file): Adjust to suit.
* ar.c (open_inarch, ranlib_touch): Likewise.
* coffdump.c (main): Likewise.
* nm.c (display_archive, display_file): Likewise.
* objcopy.c (copy_file): Likewise.
* objdump.c (display_object_bfd): Likewise.
* size.c (display_bfd): Likewise.
* srconv.c (main): Likewise.
ld/
* ldlang.c (load_symbols): Free "matching".
Diffstat (limited to 'binutils/objcopy.c')
| -rw-r--r-- | binutils/objcopy.c | 10 |
1 files changed, 2 insertions, 8 deletions
diff --git a/binutils/objcopy.c b/binutils/objcopy.c index 7ad39e8..df87712 100644 --- a/binutils/objcopy.c +++ b/binutils/objcopy.c @@ -3925,15 +3925,9 @@ copy_file (const char *input_filename, const char *output_filename, int ofd, bfd_nonfatal_message (input_filename, NULL, NULL, NULL); if (obj_error == bfd_error_file_ambiguously_recognized) - { - list_matching_formats (obj_matching); - free (obj_matching); - } + list_matching_formats (obj_matching); if (core_error == bfd_error_file_ambiguously_recognized) - { - list_matching_formats (core_matching); - free (core_matching); - } + list_matching_formats (core_matching); status = 1; } |