diff options
| author | Alan Modra <amodra@gmail.com> | 2014-12-23 19:07:23 +1030 |
|---|---|---|
| committer | Alan Modra <amodra@gmail.com> | 2014-12-23 23:36:50 +1030 |
| commit | 12b2843a6bb12292d8e36d8df22c788a3c91cb2f (patch) | |
| tree | 09f7f27839b1e5fe160a58612b5939037905e968 /bfd | |
| parent | 4cc2bf08a4e18aa2009e9d4f1694a800eacbee17 (diff) | |
| download | gdb-12b2843a6bb12292d8e36d8df22c788a3c91cb2f.zip gdb-12b2843a6bb12292d8e36d8df22c788a3c91cb2f.tar.gz gdb-12b2843a6bb12292d8e36d8df22c788a3c91cb2f.tar.bz2 | |
Use a symbol flag bit to mark linker defined symbols
Trying to use the SEC_LINKER_CREATED section flag to determine whether
a symbol is linker defined fails to work on targets like alpha that
define special SEC_COMMON sections. These might contain symbols that
originated in an object file.
include/
* bfdlink.h (struct bfd_link_hash_entry): Comment non_ir_ref. Add
linker_def.
bfd/
* elflink.c (_bfd_elf_define_linkage_sym): Set linker_def.
* linker.c (_bfd_generic_link_add_one_symbol): Clear linker_def
for CDEF, DEF, DEFW, COM.
ld/
* ldexp.c (exp_fold_tree_1 <etree_provide>): Test linker_def.
ld/testsuite/
* ld-powerpc/sdabase.s,
* ld-powerpc/sdabase.t,
* ld-powerpc/sdabase.d: New test.
* ld-powerpc/sdabase2.t,
* ld-powerpc/sdabase2.d: New test.
* ld-powerpc/powerpc.exp: Run them.
Diffstat (limited to 'bfd')
| -rw-r--r-- | bfd/ChangeLog | 6 | ||||
| -rw-r--r-- | bfd/elflink.c | 1 | ||||
| -rw-r--r-- | bfd/linker.c | 2 |
3 files changed, 9 insertions, 0 deletions
diff --git a/bfd/ChangeLog b/bfd/ChangeLog index 50ff01f..4bb379b 100644 --- a/bfd/ChangeLog +++ b/bfd/ChangeLog @@ -1,3 +1,9 @@ +2014-12-23 Alan Modra <amodra@gmail.com> + + * elflink.c (_bfd_elf_define_linkage_sym): Set linker_def. + * linker.c (_bfd_generic_link_add_one_symbol): Clear linker_def + for CDEF, DEF, DEFW, COM. + 2014-12-22 Nick Clifton <nickc@redhat.com> PR binutils/17512 diff --git a/bfd/elflink.c b/bfd/elflink.c index b701fa0..16421cf 100644 --- a/bfd/elflink.c +++ b/bfd/elflink.c @@ -85,6 +85,7 @@ _bfd_elf_define_linkage_sym (bfd *abfd, h = (struct elf_link_hash_entry *) bh; h->def_regular = 1; h->non_elf = 0; + h->root.linker_def = 1; h->type = STT_OBJECT; if (ELF_ST_VISIBILITY (h->other) != STV_INTERNAL) h->other = (h->other & ~ELF_ST_VISIBILITY (-1)) | STV_HIDDEN; diff --git a/bfd/linker.c b/bfd/linker.c index abdf5b0..9223810 100644 --- a/bfd/linker.c +++ b/bfd/linker.c @@ -1560,6 +1560,7 @@ _bfd_generic_link_add_one_symbol (struct bfd_link_info *info, h->type = bfd_link_hash_defined; h->u.def.section = section; h->u.def.value = value; + h->linker_def = 0; /* If we have been asked to, we act like collect2 and identify all functions that might be global @@ -1659,6 +1660,7 @@ _bfd_generic_link_add_one_symbol (struct bfd_link_info *info, } else h->u.c.p->section = section; + h->linker_def = 0; break; case REF: |