diff options
| author | H.J. Lu <hjl.tools@gmail.com> | 2020-03-13 07:34:56 -0700 |
|---|---|---|
| committer | H.J. Lu <hjl.tools@gmail.com> | 2020-03-13 07:39:06 -0700 |
| commit | 74e10d1742f1b8312359c59a2af06c9e661252b3 (patch) | |
| tree | 7627e27f43e85e6906a483b754ff43a93047f5c8 /bfd | |
| parent | 2d61316c32a9fa3e14786c3312d9ca87c9298db5 (diff) | |
| download | gdb-74e10d1742f1b8312359c59a2af06c9e661252b3.zip gdb-74e10d1742f1b8312359c59a2af06c9e661252b3.tar.gz gdb-74e10d1742f1b8312359c59a2af06c9e661252b3.tar.bz2 | |
x86: Check static link of dynamic objects
On Linux/x86, when -static is passed to gcc, gcc passes it to linker
before all input files suitable for creating static executable. X86
linker will report error for dynamic input objects if -static is passed
at command-line before all input files without --dynamic-linker unless
--no-dynamic-linker is used.
bfd/
PR ld/24920
* elf-linker-x86.h (elf_linker_x86_params): Add
static_before_all_inputs and has_dynamic_linker.
* elfxx-x86.c (_bfd_x86_elf_link_setup_gnu_properties): Report
dynamic input objects if -static is passed at command-line
before all input files without --dynamic-linker unless
--no-dynamic-linker is used.
ld/
PR ld/24920
* emulparams/elf32_x86_64.sh: Use static.sh.
* emulparams/elf_i386.sh: Likewise.
* emulparams/elf_x86_64.sh: Likewise.
* emulparams/static.sh: New file.
* emultempl/elf-x86.em: Include "ldlex.h".
* testsuite/ld-elf/pr24920.err: New file.
* testsuite/ld-elf/linux-x86.exp: Run ld/24920 tests.
Diffstat (limited to 'bfd')
| -rw-r--r-- | bfd/ChangeLog | 10 | ||||
| -rw-r--r-- | bfd/elf-linker-x86.h | 6 | ||||
| -rw-r--r-- | bfd/elfxx-x86.c | 17 |
3 files changed, 33 insertions, 0 deletions
diff --git a/bfd/ChangeLog b/bfd/ChangeLog index 70774e5..8b09093 100644 --- a/bfd/ChangeLog +++ b/bfd/ChangeLog @@ -1,3 +1,13 @@ +2020-03-13 H.J. Lu <hongjiu.lu@intel.com> + + PR ld/24920 + * elf-linker-x86.h (elf_linker_x86_params): Add + static_before_all_inputs and has_dynamic_linker. + * elfxx-x86.c (_bfd_x86_elf_link_setup_gnu_properties): Report + dynamic input objects if -static is passed at command-line + before all input files without --dynamic-linker unless + --no-dynamic-linker is used. + 2020-03-13 Kamil Rytarowski <n54@gmx.com> * elf.c (elfcore_grok_netbsd_note): Add support for aarch64. diff --git a/bfd/elf-linker-x86.h b/bfd/elf-linker-x86.h index 8ede729..d0cb20d 100644 --- a/bfd/elf-linker-x86.h +++ b/bfd/elf-linker-x86.h @@ -49,6 +49,12 @@ struct elf_linker_x86_params /* TRUE if generate a 1-byte NOP as suffix for x86 call instruction. */ unsigned int call_nop_as_suffix : 1; + /* TRUE if -static is passed at command-line before all input files. */ + unsigned int static_before_all_inputs : 1; + + /* TRUE if --dynamic-linker is passed at command-line. */ + unsigned int has_dynamic_linker : 1; + /* Report missing IBT and SHSTK properties. */ enum elf_x86_cet_report cet_report; diff --git a/bfd/elfxx-x86.c b/bfd/elfxx-x86.c index 2e0e01e..108e04a 100644 --- a/bfd/elfxx-x86.c +++ b/bfd/elfxx-x86.c @@ -2998,6 +2998,23 @@ _bfd_x86_elf_link_setup_gnu_properties : bed->plt_alignment); } + if (bfd_link_executable (info) + && !info->nointerp + && !htab->params->has_dynamic_linker + && htab->params->static_before_all_inputs) + { + /* Report error for dynamic input objects if -static is passed at + command-line before all input files without --dynamic-linker + unless --no-dynamic-linker is used. */ + bfd *abfd; + + for (abfd = info->input_bfds; abfd != NULL; abfd = abfd->link.next) + if ((abfd->flags & DYNAMIC)) + info->callbacks->einfo + (_("%X%P: attempted static link of dynamic object `%pB'\n"), + abfd); + } + return pbfd; } |