diff options
| author | Andreas Krebbel <krebbel@linux.vnet.ibm.com> | 2017-05-08 19:10:42 +0200 |
|---|---|---|
| committer | Andreas Krebbel <krebbel@linux.vnet.ibm.com> | 2017-05-08 19:43:20 +0200 |
| commit | d7ab4911f8aa3e1cd06ece40f74d0b4a532d6a10 (patch) | |
| tree | 08784b8961e54dd8c3f5eb0a80582c07d0b5b98c /bfd | |
| parent | f604c2a2a54ebf88e4a51986c7cdedffe7b3313a (diff) | |
| download | gdb-d7ab4911f8aa3e1cd06ece40f74d0b4a532d6a10.zip gdb-d7ab4911f8aa3e1cd06ece40f74d0b4a532d6a10.tar.gz gdb-d7ab4911f8aa3e1cd06ece40f74d0b4a532d6a10.tar.bz2 | |
S/390: Fix ifunc missing runtime reloc
This fixes a problem with a missing R_390_64 reloc against .data for a
function pointer to an ifunc function.
No regressions on s390x.
Pushed to mainline.
bfd/ChangeLog:
2017-05-08 Andreas Krebbel <krebbel@linux.vnet.ibm.com>
* elf-s390-common.c: Don't check non_got_ref flag.
* elf32-s390.c (elf_s390_relocate_section): Likewise.
* elf64-s390.c (elf_s390_relocate_section): Likewise.
Diffstat (limited to 'bfd')
| -rw-r--r-- | bfd/elf-s390-common.c | 4 | ||||
| -rw-r--r-- | bfd/elf32-s390.c | 2 | ||||
| -rw-r--r-- | bfd/elf64-s390.c | 7 |
3 files changed, 6 insertions, 7 deletions
diff --git a/bfd/elf-s390-common.c b/bfd/elf-s390-common.c index 1570365..8795fb9 100644 --- a/bfd/elf-s390-common.c +++ b/bfd/elf-s390-common.c @@ -161,9 +161,7 @@ keep: h->type = STT_FUNC; } - /* We need dynamic relocation for STT_GNU_IFUNC symbol only when - there is a non-GOT reference in a shared object. */ - if (!bfd_link_pic (info) || !h->non_got_ref) + if (!bfd_link_pic (info)) *head = NULL; /* Finally, allocate space. */ diff --git a/bfd/elf32-s390.c b/bfd/elf32-s390.c index ddb6f5b..8a09a31 100644 --- a/bfd/elf32-s390.c +++ b/bfd/elf32-s390.c @@ -2774,7 +2774,7 @@ elf_s390_relocate_section (bfd *output_bfd, && s390_is_ifunc_symbol_p (h) && h->def_regular) { - if (!bfd_link_pic (info) || !h->non_got_ref) + if (!bfd_link_pic (info)) { /* For a non-shared object STT_GNU_IFUNC symbol must go through PLT. */ diff --git a/bfd/elf64-s390.c b/bfd/elf64-s390.c index fbbf8d6..ca3541f 100644 --- a/bfd/elf64-s390.c +++ b/bfd/elf64-s390.c @@ -2737,10 +2737,11 @@ elf_s390_relocate_section (bfd *output_bfd, && s390_is_ifunc_symbol_p (h) && h->def_regular) { - if (!bfd_link_pic (info) || !h->non_got_ref) + if (!bfd_link_pic (info)) { - /* For a non-shared object STT_GNU_IFUNC symbol must - go through PLT. */ + /* For a non-shared object the symbol will not + change. Hence we can write the address of the + target IPLT slot now. */ relocation = (htab->elf.iplt->output_section->vma + htab->elf.iplt->output_offset + h ->plt.offset); |