diff options
| author | Renlin Li <renlin.li@arm.com> | 2018-03-07 09:27:45 +0000 |
|---|---|---|
| committer | Renlin Li <renlin.li@arm.com> | 2018-03-07 14:47:27 +0000 |
| commit | 0c1ded8dc0be9c61975e04a0b416b064223f7bda (patch) | |
| tree | ea5508405d2eadfb08c3a9a45c323ee66fcb5915 /bfd | |
| parent | e95a97d41a186ac65077ba3103dc10e5d41fe7b5 (diff) | |
| download | gdb-0c1ded8dc0be9c61975e04a0b416b064223f7bda.zip gdb-0c1ded8dc0be9c61975e04a0b416b064223f7bda.tar.gz gdb-0c1ded8dc0be9c61975e04a0b416b064223f7bda.tar.bz2 | |
[PR20402][LD][AARCH64]Don't emit RELATIVE relocation for absolute symbols which are resolved at static linking time.
For absolute symbols which are forced local or not dynamic, the ABS relocation
should be resolved at static linking time.
Originally, an RELATIVE/ABS relocation will be generated even for absolution
symbols for the dynamic linker to resolve.
bfd/
2018-03-07 Renlin Li <renlin.li@arm.com>
PR ld/20402
* elfnn-aarch64.c (elfNN_aarch64_final_link_relocate): Check absolute symbol,
and don't emit relocation in specific case.
ld/
2018-03-07 Renlin Li <renlin.li@arm.com>
PR ld/20402
* testsuite/ld-aarch64/aarch64-elf.exp: Run new test.
* testsuite/ld-aarch64/pr20402.s: New.
* testsuite/ld-aarch64/pr20402.d: New.
Diffstat (limited to 'bfd')
| -rw-r--r-- | bfd/ChangeLog | 6 | ||||
| -rw-r--r-- | bfd/elfnn-aarch64.c | 13 |
2 files changed, 17 insertions, 2 deletions
diff --git a/bfd/ChangeLog b/bfd/ChangeLog index 09fae15..c0ad7eb 100644 --- a/bfd/ChangeLog +++ b/bfd/ChangeLog @@ -1,3 +1,9 @@ +2018-03-07 Renlin Li <renlin.li@arm.com> + + PR ld/20402 + * elfnn-aarch64.c (elfNN_aarch64_final_link_relocate): Check absolute + symbol, and don't emit relocation in specific case. + 2018-03-07 Alan Modra <amodra@gmail.com> * elf64-mips.c (mips_elf64_rtype_to_howto): Return NULL on error. diff --git a/bfd/elfnn-aarch64.c b/bfd/elfnn-aarch64.c index dc24df8..beef91a 100644 --- a/bfd/elfnn-aarch64.c +++ b/bfd/elfnn-aarch64.c @@ -5074,6 +5074,7 @@ elfNN_aarch64_final_link_relocate (reloc_howto_type *howto, asection *base_got; bfd_vma orig_value = value; bfd_boolean resolved_to_zero; + bfd_boolean abs_symbol_p; globals = elf_aarch64_hash_table (info); @@ -5093,6 +5094,9 @@ elfNN_aarch64_final_link_relocate (reloc_howto_type *howto, weak_undef_p = (h ? h->root.type == bfd_link_hash_undefweak : bfd_is_und_section (sym_sec)); + abs_symbol_p = (h !=NULL && h->root.type == bfd_link_hash_defined + && bfd_is_abs_section (h->root.u.def.section)); + /* Since STT_GNU_IFUNC symbol must go through PLT, we handle it here if it is defined in a non-shared object. */ @@ -5360,6 +5364,12 @@ bad_ifunc_reloc: skip = TRUE; relocate = TRUE; } + else if (abs_symbol_p) + { + /* Local absolute symbol. */ + skip = (h->forced_local || (h->dynindx == -1)); + relocate = skip; + } outrel.r_offset += (input_section->output_section->vma + input_section->output_offset); @@ -5369,8 +5379,7 @@ bad_ifunc_reloc: else if (h != NULL && h->dynindx != -1 && (!bfd_link_pic (info) - || !(bfd_link_pie (info) - || SYMBOLIC_BIND (info, h)) + || !(bfd_link_pie (info) || SYMBOLIC_BIND (info, h)) || !h->def_regular)) outrel.r_info = ELFNN_R_INFO (h->dynindx, r_type); else |