diff options
| author | Alan Modra <amodra@gmail.com> | 2016-10-05 16:52:24 +1030 |
|---|---|---|
| committer | Alan Modra <amodra@gmail.com> | 2016-10-06 09:39:56 +1030 |
| commit | 2b804145796e948fa4c025c07eb201e700281e6b (patch) | |
| tree | c1a7b298379035822fa1d77ebe2a9a82d71fdca4 /bfd | |
| parent | d8e9025191bc7b8ac1ffe28612a9015cd238f5b2 (diff) | |
| download | gdb-2b804145796e948fa4c025c07eb201e700281e6b.zip gdb-2b804145796e948fa4c025c07eb201e700281e6b.tar.gz gdb-2b804145796e948fa4c025c07eb201e700281e6b.tar.bz2 | |
-Wimplicit-fallthrough error fixes
Well, not all are errors, but a little more substantive than just
fiddling with comments.
bfd/
* coffcode.h (coff_slurp_symbol_table): Revert accidental commit
made 2015-01-08.
* elf32-nds32.c (nds32_elf_grok_psinfo): Add missing break.
* reloc.c (bfd_default_reloc_type_lookup): Add missing breaks.
opcodes/
* arc-ext.c (create_map): Add missing break.
* msp430-decode.opc (encode_as): Likewise.
* msp430-decode.c: Regenerate.
binutils/
* coffdump.c (dump_coff_where): Add missing break.
* stabs.c (stab_xcoff_builtin_type): Likewise.
gas/
* config/tc-arc.c (find_opcode_match): Add missing break.
* config/tc-i960.c (get_cdisp): Likewise.
* config/tc-metag.c (parse_swap, md_apply_fix): Likewise.
* config/tc-mt.c (md_parse_option): Likewise.
* config/tc-nds32.c (nds32_apply_fix): Likewise.
* config/tc-hppa.c (pa_ip): Assert rather than testing last
condition of multiple if statements.
* config/tc-s390.c (s390_exp_compare): Return 0 on error.
* config/tc-tic4x.c (tic4x_operand_parse): Add as_bad and break
out of case rather than falling into next case. Formatting.
ld/
* plugin.c (asymbol_from_plugin_symbol): Avoid compiler warning
by adding return.
Diffstat (limited to 'bfd')
| -rw-r--r-- | bfd/ChangeLog | 7 | ||||
| -rw-r--r-- | bfd/coffcode.h | 4 | ||||
| -rw-r--r-- | bfd/elf32-nds32.c | 1 | ||||
| -rw-r--r-- | bfd/reloc.c | 2 |
4 files changed, 12 insertions, 2 deletions
diff --git a/bfd/ChangeLog b/bfd/ChangeLog index 7ba9597..11381ea 100644 --- a/bfd/ChangeLog +++ b/bfd/ChangeLog @@ -1,5 +1,12 @@ 2016-10-06 Alan Modra <amodra@gmail.com> + * coffcode.h (coff_slurp_symbol_table): Revert accidental commit + made 2015-01-08. + * elf32-nds32.c (nds32_elf_grok_psinfo): Add missing break. + * reloc.c (bfd_default_reloc_type_lookup): Add missing breaks. + +2016-10-06 Alan Modra <amodra@gmail.com> + * elf32-epiphany.c (epiphany_final_link_relocate): Use bitwise OR in arithmetic expression, not boolean OR. diff --git a/bfd/coffcode.h b/bfd/coffcode.h index 20829fc..31050ec 100644 --- a/bfd/coffcode.h +++ b/bfd/coffcode.h @@ -5055,14 +5055,14 @@ coff_slurp_symbol_table (bfd * abfd) #if defined(TIC80COFF) || defined(TICOFF) case C_UEXT: /* Tentative external definition. */ #endif + case C_EXTLAB: /* External load time label. */ + case C_HIDDEN: /* Ext symbol in dmert public lib. */ default: _bfd_error_handler (_("%B: Unrecognized storage class %d for %s symbol `%s'"), abfd, src->u.syment.n_sclass, dst->symbol.section->name, dst->symbol.name); ret = FALSE; - case C_EXTLAB: /* External load time label. */ - case C_HIDDEN: /* Ext symbol in dmert public lib. */ dst->symbol.flags = BSF_DEBUGGING; dst->symbol.value = (src->u.syment.n_value); break; diff --git a/bfd/elf32-nds32.c b/bfd/elf32-nds32.c index fc47c7f..0f2d6da 100644 --- a/bfd/elf32-nds32.c +++ b/bfd/elf32-nds32.c @@ -3046,6 +3046,7 @@ nds32_elf_grok_psinfo (bfd *abfd, Elf_Internal_Note *note) _bfd_elfcore_strndup (abfd, note->descdata + 28, 16); elf_tdata (abfd)->core->command = _bfd_elfcore_strndup (abfd, note->descdata + 44, 80); + break; default: return FALSE; diff --git a/bfd/reloc.c b/bfd/reloc.c index dbaa6a9..58cffdf 100644 --- a/bfd/reloc.c +++ b/bfd/reloc.c @@ -7770,10 +7770,12 @@ bfd_default_reloc_type_lookup (bfd *abfd, bfd_reloc_code_real_type code) { case 64: BFD_FAIL (); + break; case 32: return &bfd_howto_32; case 16: BFD_FAIL (); + break; default: BFD_FAIL (); } |